sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel/bd82x6x: Use {get,set}_int_option

Browse Source 
Change-Id: Icbfea8c516c42b45d689da92b7e426cb6d5112a5
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52509
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Angel Pons
2021-04-19 13:21:41 +02:00
committed by Patrick Georgi
parent 0a937754ee
commit 5daa412939
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/southbridge/intel/bd82x6x/me.c
View File

@@ -178,15 +178,14 @@ static int mkhi_get_fwcaps(void)
static void intel_me_init(struct device *dev) static void intel_me_init(struct device *dev)
{ {
me_bios_path path = intel_me_path(dev); me_bios_path path = intel_me_path(dev);
u8 me_state = 0, me_state_prev = 0;
bool need_reset = false; bool need_reset = false;
union me_hfs hfs; union me_hfs hfs;
/* Do initial setup and determine the BIOS path */ /* Do initial setup and determine the BIOS path */
printk(BIOS_NOTICE, "ME: BIOS path: %s\n", me_get_bios_path_string(path)); printk(BIOS_NOTICE, "ME: BIOS path: %s\n", me_get_bios_path_string(path));
get_option(&me_state, "me_state"); u8 me_state = get_int_option("me_state", 0);
get_option(&me_state_prev, "me_state_prev"); u8 me_state_prev = get_int_option("me_state_prev", 0);
printk(BIOS_DEBUG, "ME: me_state=%u, me_state_prev=%u\n", me_state, me_state_prev); printk(BIOS_DEBUG, "ME: me_state=%u, me_state_prev=%u\n", me_state, me_state_prev);
@@ -269,7 +268,7 @@ static void intel_me_init(struct device *dev)
set the 'changed' bit here. */ set the 'changed' bit here. */
if (me_state != CMOS_ME_STATE(me_state_prev) || need_reset) { if (me_state != CMOS_ME_STATE(me_state_prev) || need_reset) {
u8 new_state = me_state | CMOS_ME_STATE_CHANGED; u8 new_state = me_state | CMOS_ME_STATE_CHANGED;
set_option("me_state_prev", &new_state); set_int_option("me_state_prev", new_state);
} }
if (need_reset) { if (need_reset) {

7
src/southbridge/intel/bd82x6x/me_8.x.c
View File

@@ -176,15 +176,14 @@ static void intel_me_init(struct device *dev)
{ {
me_bios_path path = intel_me_path(dev); me_bios_path path = intel_me_path(dev);
me_bios_payload mbp_data; me_bios_payload mbp_data;
u8 me_state = 0, me_state_prev = 0;
bool need_reset = false; bool need_reset = false;
union me_hfs hfs; union me_hfs hfs;
/* Do initial setup and determine the BIOS path */ /* Do initial setup and determine the BIOS path */
printk(BIOS_NOTICE, "ME: BIOS path: %s\n", me_get_bios_path_string(path)); printk(BIOS_NOTICE, "ME: BIOS path: %s\n", me_get_bios_path_string(path));
get_option(&me_state, "me_state"); u8 me_state = get_int_option("me_state", 0);
get_option(&me_state_prev, "me_state_prev"); u8 me_state_prev = get_int_option("me_state_prev", 0);
printk(BIOS_DEBUG, "ME: me_state=%u, me_state_prev=%u\n", me_state, me_state_prev); printk(BIOS_DEBUG, "ME: me_state=%u, me_state_prev=%u\n", me_state, me_state_prev);
@@ -268,7 +267,7 @@ static void intel_me_init(struct device *dev)
set the 'changed' bit here. */ set the 'changed' bit here. */
if (me_state != CMOS_ME_STATE(me_state_prev) || need_reset) { if (me_state != CMOS_ME_STATE(me_state_prev) || need_reset) {
u8 new_state = me_state | CMOS_ME_STATE_CHANGED; u8 new_state = me_state | CMOS_ME_STATE_CHANGED;
set_option("me_state_prev", &new_state); set_int_option("me_state_prev", new_state);
} }
if (need_reset) { if (need_reset) {