sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/*/{x201,ms2290}/mainboard.c: Remove superfluous ramstage code

Browse Source 
Change-Id: I0270c50dea2a2ce6c8e6114ed708f06be9d33c0e
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33141
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Arthur Heymans
2019-05-28 10:10:25 +02:00
committed by Patrick Georgi
parent 279d8b5f3d
commit 5ea2e405da
2 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/mainboard/lenovo/x201/mainboard.c
View File

@@ -35,23 +35,8 @@ static void fill_ssdt(struct device *device)
static void mainboard_enable(struct device *dev) static void mainboard_enable(struct device *dev)
{ {
u16 pmbase;
dev->ops->acpi_fill_ssdt_generator = fill_ssdt; dev->ops->acpi_fill_ssdt_generator = fill_ssdt;
pmbase = pci_read_config32(pcidev_on_root(0x1f, 0),
PMBASE) & 0xff80;
printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", pmbase);
outl(0, pmbase + SMI_EN);
enable_lapic();
pci_write_config32(pcidev_on_root(0x1f, 0), GPIO_BASE,
DEFAULT_GPIOBASE | 1);
pci_write_config8(pcidev_on_root(0x1f, 0), GPIO_CNTL,
0x10);
/* If we're resuming from suspend, blink suspend LED */ /* If we're resuming from suspend, blink suspend LED */
if (acpi_is_wakeup_s3()) if (acpi_is_wakeup_s3())
ec_write(0x0c, 0xc7); ec_write(0x0c, 0xc7);

15
src/mainboard/packardbell/ms2290/mainboard.c
View File

@@ -32,8 +32,6 @@
static void mainboard_enable(struct device *dev) static void mainboard_enable(struct device *dev)
{ {
u16 pmbase;
int i; int i;
const u8 dmp[256] = { const u8 dmp[256] = {
0x00, 0x20, 0x00, 0x00, 0x00, 0x02, 0x89, 0xe4, 0x30, 0x00, 0x40, 0x14, 0x00, 0x00, 0x00, 0x11, 0x00, 0x20, 0x00, 0x00, 0x00, 0x02, 0x89, 0xe4, 0x30, 0x00, 0x40, 0x14, 0x00, 0x00, 0x00, 0x11,
@@ -57,19 +55,6 @@ static void mainboard_enable(struct device *dev)
for (i = 0; i < 256; i++) for (i = 0; i < 256; i++)
ec_write (i, dmp[i]); ec_write (i, dmp[i]);
pmbase = pci_read_config32(pcidev_on_root(0x1f, 0),
PMBASE) & 0xff80;
printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", pmbase);
outl(0, pmbase + SMI_EN);
enable_lapic();
pci_write_config32(pcidev_on_root(0x1f, 0), GPIO_BASE,
DEFAULT_GPIOBASE | 1);
pci_write_config8(pcidev_on_root(0x1f, 0), GPIO_CNTL,
0x10);
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_LFP, 2); install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_LFP, 2);
/* This sneaked in here, because EasyNote has no SuperIO chip. /* This sneaked in here, because EasyNote has no SuperIO chip.