sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/s230u: Fix USBDEBUG check

Browse Source 
- Change preprocessor #if to standard C if.  This will get optimized
out if the config option is disabled, but lets the compiler check the
contents.
- CONFIG_USBDEBUG is always going to be defined even if it's disabled,
so this check is not going to work as expected.
See the coreboot Kconfig documentation in /Documentation/core/Kconfig.md

Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/18974
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Martin Roth
2017-03-24 11:08:32 -06:00
parent f0eda827b8
commit 5ef5c00704
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/lenovo/s230u/romstage.c
View File

@@ -51,10 +51,9 @@ void pch_enable_lpc(void)
CONFIG_EC_BASE_ADDRESS | 1); CONFIG_EC_BASE_ADDRESS | 1);
pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xd8, 0xffc0); pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xd8, 0xffc0);
#ifdef CONFIG_USBDEBUG
/* Enable external USB port power. */ /* Enable external USB port power. */
ec_mm_set_bit(0x3b, 4); if (IS_ENABLED(CONFIG_USBDEBUG))
#endif ec_mm_set_bit(0x3b, 4);
} }
void rcba_config(void) void rcba_config(void)