sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec: Use DEVICE_NOOP macro formalism over static stub func

Browse Source 
The in source comment:

	/* This function avoids an error on serial console. */

refers to the resource allocator needing to find a non-NULL
function pointer else complaints of "... missing read_resources"
will be spewed.

Unfortunately/fortunately (depending on the time of day) compiler
optimisers have gotten a bit better at optimising away no-op functions
leading to the very message these stubs attempted to avoid. By using
the DEVICE_NOOP formalism that is static inlined 'suggests' (not enforces)
to the compiler to keep these symbols around.

Change-Id: I182019627b6954a4020f9f70e9c829ce3135f63c
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7598
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Edward O'Callaghan
2014-11-29 00:03:03 +11:00
parent d3060edce2
commit 5f19eb6f40
3 changed files with 6 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/ec/compal/ene932/ec.c
View File

@@ -142,22 +142,10 @@ static void ene932_init(struct device *dev)
} }
static void ene932_read_resources(struct device *dev)
{
/* This function avoids an error on serial console. */
}
static void ene932_enable_resources(struct device *dev)
{
/* This function avoids an error on serial console. */
}
static struct device_operations ops = { static struct device_operations ops = {
.init = ene932_init, .init = ene932_init,
.read_resources = ene932_read_resources, .read_resources = DEVICE_NOOP,
.enable_resources = ene932_enable_resources .enable_resources = DEVICE_NOOP,
}; };
static struct pnp_info pnp_dev_info[] = { static struct pnp_info pnp_dev_info[] = {

16
src/ec/quanta/ene_kb3940q/ec.c
View File

@@ -152,22 +152,10 @@ static void ene_kb3940q_init(struct device *dev)
ene_kb3940q_log_events(); ene_kb3940q_log_events();
} }
static void ene_kb3940q_read_resources(struct device *dev)
{
/* This function avoids an error on serial console. */
}
static void ene_kb3940q_enable_resources(struct device *dev)
{
/* This function avoids an error on serial console. */
}
static struct device_operations ops = { static struct device_operations ops = {
.init = ene_kb3940q_init, .init = ene_kb3940q_init,
.read_resources = ene_kb3940q_read_resources, .read_resources = DEVICE_NOOP,
.enable_resources = ene_kb3940q_enable_resources .enable_resources = DEVICE_NOOP,
}; };
static struct pnp_info pnp_dev_info[] = { static struct pnp_info pnp_dev_info[] = {

16
src/ec/quanta/it8518/ec.c
View File

@@ -165,22 +165,10 @@ static void it8518_init(struct device *dev)
pc_keyboard_init(); pc_keyboard_init();
} }
static void it8518_read_resources(struct device *dev)
{
/* This function avoids an error on serial console. */
}
static void it8518_enable_resources(struct device *dev)
{
/* This function avoids an error on serial console. */
}
static struct device_operations ops = { static struct device_operations ops = {
.init = it8518_init, .init = it8518_init,
.read_resources = it8518_read_resources, .read_resources = DEVICE_NOOP,
.enable_resources = it8518_enable_resources .enable_resources = DEVICE_NOOP,
}; };
static struct pnp_info pnp_dev_info[] = { static struct pnp_info pnp_dev_info[] = {