sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skylake: Control fixed IO decode from devicetree

Browse Source 
The current implementation doesn't allow custom values for the LPC IO
decodes and IO enables.

Add the lpc_ioe and lpc_iod values. If they are not zero, they will be
used instead of the current handling for COMA and COMB.

BUG=N/A
TEST=tested on facebook monolith

Change-Id: Iad7bb0e44739e8d656a542c79af7f98a4e9bde69
Signed-off-by: Wim Vervoorn <wvervoorn@eltan.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38748
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Wim Vervoorn
2020-02-03 15:32:54 +01:00
committed by Patrick Georgi
parent 53a9e41891
commit 5f2adfe1a3
4 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/soc/intel/skylake/bootblock/pch.c
View File

@@ -127,9 +127,16 @@ void pch_early_iorange_init(void)
uint16_t io_enables = LPC_IOE_SUPERIO_2E_2F | LPC_IOE_KBC_60_64 |
LPC_IOE_EC_62_66;
/* IO Decode Range */
if (CONFIG(DRIVERS_UART_8250IO))
lpc_io_setup_comm_a_b();
const config_t *config = config_of_soc();
if (config->lpc_ioe) {
io_enables = config->lpc_ioe & 0x3f0f;
lpc_set_fixed_io_ranges(config->lpc_iod, 0x1377);
} else {
/* IO Decode Range */
if (CONFIG(DRIVERS_UART_8250IO))
lpc_io_setup_comm_a_b();
}
/* IO Decode Enable */
if (pch_check_decode_enable() == 0) {

4
src/soc/intel/skylake/chip.h
View File

@@ -79,6 +79,10 @@ struct soc_intel_skylake_config {
uint8_t gpe0_dw1; /* GPE0_63_32 STS/EN */
uint8_t gpe0_dw2; /* GPE0_95_64 STS/EN */
/* LPC fixed enables and ranges */
uint16_t lpc_iod;
uint16_t lpc_ioe;
/* Generic IO decode ranges */
uint32_t gen1_dec;
uint32_t gen2_dec;