sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload: Enable -Wimplicit-fallthrough

Browse Source 
Add comments to intentional fall throughs and enable the warning.

Change-Id: I93e071c4fb139fa6e9cd8a1bfb5800f5f4eac50b
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34457
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
Jacob Garber
2019-07-19 17:35:28 -06:00
committed by Martin Roth
parent ae317695e3
commit 5f7b1164c5
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
payloads/libpayload/libc/printf.c
View File

@ -585,6 +585,7 @@ static int printf_core(const char *fmt, struct printf_spec *ps, va_list ap)
/* Integer values */
case 'P': /* pointer */
flags |= __PRINTF_FLAG_BIGCHARS;
/* fall through */
case 'p':
flags |= __PRINTF_FLAG_PREFIX;
base = 16;
@ -599,10 +600,12 @@ static int printf_core(const char *fmt, struct printf_spec *ps, va_list ap)
case 'd':
case 'i':
flags |= __PRINTF_FLAG_SIGNED;
break;
case 'u':
break;
case 'X':
flags |= __PRINTF_FLAG_BIGCHARS;
/* fall through */
case 'x':
base = 16;
break;