soc/amd/common: Remove AmdReadEventLog()
Parameter passing is incorrect here, it should pass complete StdHeader instead of attempting to fill in HeapStatus that should be treated as a field private to AGESA, based on where it is defined in the header files. Furthermore the while() loop did not evaluate the return value. Feature can be brought back at a later date after someone verifies it actually works correctly across different stages. Change-Id: Ib243b275f8700ecaeb330772c795d305c61899c5 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/31484 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
committed by
Patrick Georgi
parent
6e512c4d7a
commit
63bc18e328
@ -226,17 +226,3 @@ AmdLateRunApTask (
|
||||
if (!Dispatcher) return AGESA_UNSUPPORTED;
|
||||
return Dispatcher(AmdApExeParams);
|
||||
}
|
||||
|
||||
/**********************************************************************
|
||||
* Interface service call: AmdReadEventLog
|
||||
**********************************************************************/
|
||||
AGESA_STATUS
|
||||
AmdReadEventLog (
|
||||
IN EVENT_PARAMS *Event
|
||||
)
|
||||
{
|
||||
MODULE_ENTRY Dispatcher = agesa_get_dispatcher();
|
||||
Event->StdHeader.Func = AMD_READ_EVENT_LOG;
|
||||
if (!Dispatcher) return AGESA_UNSUPPORTED;
|
||||
return Dispatcher(Event);
|
||||
}
|
||||
|
Reference in New Issue
Block a user