libpayload: Fix potential NULL pointer dereference
Found-by: Klockwork BUG=NONE TEST=Boot to OS on GLK Sparky Signed-off-by: Francois Toguo <francois.toguo.fotso@intel.com> Change-Id: I9d4636f0429de829e746909492c2f543026a02ac Reviewed-on: https://review.coreboot.org/c/coreboot/+/32083 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Lijian Zhao <lijian.zhao@intel.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
committed by
Patrick Georgi
parent
e0c181d487
commit
651d8dd4f6
@@ -317,6 +317,8 @@ uhci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq, int dalen
|
||||
unsigned short req = ((unsigned short *) devreq)[0];
|
||||
int i;
|
||||
td_t *tds = memalign (16, sizeof (td_t) * count);
|
||||
if (!tds)
|
||||
fatal("Not enough memory for uhci control.\n");
|
||||
memset (tds, 0, sizeof (td_t) * count);
|
||||
count--; /* to compensate for 0-indexed array */
|
||||
for (i = 0; i < count; i++) {
|
||||
@@ -386,6 +388,8 @@ create_schedule (int numpackets)
|
||||
if (numpackets == 0)
|
||||
return 0;
|
||||
td_t *tds = memalign (16, sizeof (td_t) * numpackets);
|
||||
if (!tds)
|
||||
fatal("Not enough memory for packets scheduling.\n");
|
||||
memset (tds, 0, sizeof (td_t) * numpackets);
|
||||
int i;
|
||||
for (i = 0; i < numpackets; i++) {
|
||||
|
Reference in New Issue
Block a user