sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Documentation: Rework staging and commit information

Browse Source 
This patch does two things:
- The CLI and Git Cola sections contained some duplicated information
  about pushing patches, which is now factored out into its own section.
- The draft workflow is now disabled, so that part has been reworded to
  describe how to submit a private patch.

Signed-off-by: David Hendricks <david.hendricks@gmail.com>
Change-Id: I562c101ab2ee78d901be7e99165daba7473dc3c1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37256
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
David Hendricks
2019-11-26 15:46:44 -08:00
committed by Patrick Georgi
parent c4b7ad4db5
commit 6572fe538a
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Documentation/tutorial/part2.md
View File

@@ -157,10 +157,10 @@ commit, you wish to make changes to it, running `git commit --amend` allows
you to take back your commit and amend it. you to take back your commit and amend it.
When you are done with your commit, run `git push` to push your commit to When you are done with your commit, run `git push` to push your commit to
coreboot.org. **Note:** To submit as a draft, use coreboot.org. **Note:** To submit as a private patch, use
`git push origin HEAD:refs/drafts/master`. Submitting as a draft means that `git push origin HEAD:refs/for/master%private`. Submitting as a private patch
your commit will be on coreboot.org, but is only visible to those you add means that your commit will be on review.coreboot.org, but is only visible to
as reviewers. yourself and those you add as reviewers.
This has been a quick primer on how to submit a change to Gerrit for review This has been a quick primer on how to submit a change to Gerrit for review
using git. You may wish to review the [Gerrit code review workflow using git. You may wish to review the [Gerrit code review workflow
@@ -227,9 +227,6 @@ explained in the extended description.
When ready, select 'Commit' again. Once all errors have been satisfied When ready, select 'Commit' again. Once all errors have been satisfied
and the commit succeeds, move to the command line and run `git push`. and the commit succeeds, move to the command line and run `git push`.
**Note:** To submit as a draft, use `git push origin HEAD:refs/drafts/master`.
Submitting as a draft means that your commit will be on coreboot.org, but is
only visible to those you add as reviewers.
## Part 5: Getting your commit reviewed ## Part 5: Getting your commit reviewed