sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/i2c/w83795: Fix tautology from wrong return type

Browse Source 
The correct type-signature of 'do_smbus_write_byte' is:

 int do_smbus_write_byte(u32 smbus_io_base, u32 device, u32 address, u8 val)

and so storing the return type in a 'u32' is inappropriate, leading
to a tautological compare of 'ret < 0' and 'err < 0'.

Change-Id: I65486df7156c70af84fa00c336142d9a45998620
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/8209
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Edward O'Callaghan
2015-01-14 02:14:21 +11:00
parent b0a00c996d
commit 660ec7cfdf
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/drivers/i2c/w83795/w83795.c
View File

@@ -24,14 +24,14 @@
#include "southbridge/amd/cimx/sb700/smbus.h" /*SMBUS_IO_BASE*/ #include "southbridge/amd/cimx/sb700/smbus.h" /*SMBUS_IO_BASE*/
#include "w83795.h" #include "w83795.h"
static u32 w83795_set_bank(u8 bank) static int w83795_set_bank(u8 bank)
{ {
return do_smbus_write_byte(SMBUS_IO_BASE, W83795_DEV, W83795_REG_BANKSEL, bank); return do_smbus_write_byte(SMBUS_IO_BASE, W83795_DEV, W83795_REG_BANKSEL, bank);
} }
static u8 w83795_read(u16 reg) static u8 w83795_read(u16 reg)
{ {
u32 ret; int ret;
ret = w83795_set_bank(reg >> 8); ret = w83795_set_bank(reg >> 8);
if (ret < 0) { if (ret < 0) {
@@ -45,7 +45,7 @@ static u8 w83795_read(u16 reg)
static u8 w83795_write(u16 reg, u8 value) static u8 w83795_write(u16 reg, u8 value)
{ {
u32 err; int err;
err = w83795_set_bank(reg >> 8); err = w83795_set_bank(reg >> 8);
if (err < 0) { if (err < 0) {