sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory_info.h: Store SMBIOS error correction type

Browse Source 
There are platforms that support error correction types other than
single-bit ECC. Extend meminfo to accomodate additional ECC types.

It is assumed that `struct memory_info` is packed to save space. Thus,
use `uint8_t` instead of an enum type (which are usually 4 bytes wide).

Change-Id: I863f8e34c84841d931dfb8d7067af0f12a437e36
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50178
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons
2021-01-31 15:06:59 +01:00
committed by Patrick Georgi
parent 69ff428159
commit 6724ba4f04
5 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/northbridge/intel/sandybridge/raminit.c
View File

@ -53,9 +53,9 @@ static void disable_channel(ramctr_timing *ctrl, int channel)
memset(&ctrl->info.dimm[channel][0], 0, sizeof(ctrl->info.dimm[0]));
}
static bool nb_supports_ecc(const uint32_t capid0_a)
static uint8_t nb_get_ecc_type(const uint32_t capid0_a)
{
return !(capid0_a & CAPID_ECCDIS);
return capid0_a & CAPID_ECCDIS ? MEMORY_ARRAY_ECC_NONE : MEMORY_ARRAY_ECC_SINGLE_BIT;
}
static uint16_t nb_slots_per_channel(const uint32_t capid0_a)
@ -114,7 +114,7 @@ static void setup_sdram_meminfo(ramctr_timing *ctrl)
const uint16_t channels = nb_number_of_channels(capid0_a);
m->ecc_capable = nb_supports_ecc(capid0_a);
m->ecc_type = nb_get_ecc_type(capid0_a);
m->max_capacity_mib = channels * nb_max_chan_capacity_mib(capid0_a);
m->number_of_devices = channels * nb_slots_per_channel(capid0_a);
}