sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp/uncore_acpi: Fix debug print

Browse Source 
The DMAR entries of type "PCI" have no "Enumeration ID" and thus
there's no need to print it. Drop all unused Enumeration IDs to
simplify the code and debug prints.

Document ID: Intel Virtualization Technology for Directed I/O
Architecture Specification, Rev. 4.0, Order Number: D51397-015

TEST=intel/archercity CRB

Change-Id: I009fbfb9f9d62855d351c5db2d3d88722b5dbfa2
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81186
Reviewed-by: Shuo Liu <shuo.liu@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph
2024-03-12 19:34:27 +01:00
committed by Felix Held
parent 3e4b517265
commit 686d810092
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/soc/intel/xeon_sp/uncore_acpi.c
View File

@@ -240,9 +240,7 @@ static unsigned long acpi_create_dmar_ds_pci_br_for_port(unsigned long current,
*first = false; *first = false;
} }
printk(BIOS_DEBUG, " [PCI Bridge Device] Enumeration ID: 0x%x, " printk(BIOS_DEBUG, " [PCI Bridge Device] %s\n", dev_path(bridge_dev));
"PCI Bus Number: 0x%x, PCI Path: 0x%x, 0x%x\n",
0, bus, dev, func);
pci_br_size = acpi_create_dmar_ds_pci_br(current + atsr_size, bus, dev, func); pci_br_size = acpi_create_dmar_ds_pci_br(current + atsr_size, bus, dev, func);
return (atsr_size + pci_br_size); return (atsr_size + pci_br_size);
@@ -307,9 +305,9 @@ static unsigned long acpi_create_drhd(unsigned long current, struct device *iomm
// Add CBDMA devices for CSTACK // Add CBDMA devices for CSTACK
if (socket != 0 && stack == CSTACK) { if (socket != 0 && stack == CSTACK) {
for (int cbdma_func_id = 0; cbdma_func_id < 8; ++cbdma_func_id) { for (int cbdma_func_id = 0; cbdma_func_id < 8; ++cbdma_func_id) {
printk(BIOS_DEBUG, " [PCI Endpoint Device] Enumeration ID: 0x%x, " printk(BIOS_DEBUG, " [PCI Endpoint Device] "
"PCI Bus Number: 0x%x, PCI Path: 0x%x, 0x%x\n", "PCI Bus Number: 0x%x, PCI Path: 0x%x, 0x%x\n",
0, bus, CBDMA_DEV_NUM, cbdma_func_id); bus, CBDMA_DEV_NUM, cbdma_func_id);
current += acpi_create_dmar_ds_pci(current, current += acpi_create_dmar_ds_pci(current,
bus, CBDMA_DEV_NUM, cbdma_func_id); bus, CBDMA_DEV_NUM, cbdma_func_id);
} }
@@ -330,9 +328,9 @@ static unsigned long acpi_create_drhd(unsigned long current, struct device *iomm
// Add VMD // Add VMD
if (hob->PlatformData.VMDStackEnable[socket][stack] && if (hob->PlatformData.VMDStackEnable[socket][stack] &&
stack >= PSTACK0 && stack <= PSTACK2) { stack >= PSTACK0 && stack <= PSTACK2) {
printk(BIOS_DEBUG, " [PCI Endpoint Device] Enumeration ID: 0x%x, " printk(BIOS_DEBUG, " [PCI Endpoint Device] "
"PCI Bus Number: 0x%x, PCI Path: 0x%x, 0x%x\n", "PCI Bus Number: 0x%x, PCI Path: 0x%x, 0x%x\n",
0, bus, VMD_DEV_NUM, VMD_FUNC_NUM); bus, VMD_DEV_NUM, VMD_FUNC_NUM);
current += acpi_create_dmar_ds_pci(current, current += acpi_create_dmar_ds_pci(current,
bus, VMD_DEV_NUM, VMD_FUNC_NUM); bus, VMD_DEV_NUM, VMD_FUNC_NUM);
} }
@@ -352,9 +350,7 @@ static unsigned long acpi_create_drhd(unsigned long current, struct device *iomm
const uint32_t b = dev->upstream->secondary; const uint32_t b = dev->upstream->secondary;
const uint32_t d = PCI_SLOT(dev->path.pci.devfn); const uint32_t d = PCI_SLOT(dev->path.pci.devfn);
const uint32_t f = PCI_FUNC(dev->path.pci.devfn); const uint32_t f = PCI_FUNC(dev->path.pci.devfn);
printk(BIOS_DEBUG, " [PCIE Endpoint Device] " printk(BIOS_DEBUG, " [PCIE Endpoint Device] %s\n", dev_path(dev));
"Enumeration ID: 0x%x, PCI Bus Number: 0x%x, "
" PCI Path: 0x%x, 0x%x\n", 0, b, d, f);
current += acpi_create_dmar_ds_pci(current, b, d, f); current += acpi_create_dmar_ds_pci(current, b, d, f);
} }
} }
@@ -462,9 +458,9 @@ static unsigned long acpi_create_rmrr(unsigned long current)
current += acpi_create_dmar_rmrr(current, 0, (uint32_t)ptr, current += acpi_create_dmar_rmrr(current, 0, (uint32_t)ptr,
(uint32_t)((uint32_t)ptr + size - 1)); (uint32_t)((uint32_t)ptr + size - 1));
printk(BIOS_DEBUG, " [PCI Endpoint Device] Enumeration ID: 0x%x, PCI Bus Number: 0x%x, " printk(BIOS_DEBUG, " [PCI Endpoint Device] PCI Bus Number: 0x%x, "
"PCI Path: 0x%x, 0x%x\n", "PCI Path: 0x%x, 0x%x\n",
0, XHCI_BUS_NUMBER, PCH_DEV_SLOT_XHCI, XHCI_FUNC_NUM); XHCI_BUS_NUMBER, PCH_DEV_SLOT_XHCI, XHCI_FUNC_NUM);
current += acpi_create_dmar_ds_pci(current, XHCI_BUS_NUMBER, current += acpi_create_dmar_ds_pci(current, XHCI_BUS_NUMBER,
PCH_DEV_SLOT_XHCI, XHCI_FUNC_NUM); PCH_DEV_SLOT_XHCI, XHCI_FUNC_NUM);
@@ -503,9 +499,7 @@ static unsigned long xeonsp_create_satc(unsigned long current, struct device *do
const uint32_t b = domain->downstream->secondary; const uint32_t b = domain->downstream->secondary;
const uint32_t d = PCI_SLOT(dev->path.pci.devfn); const uint32_t d = PCI_SLOT(dev->path.pci.devfn);
const uint32_t f = PCI_FUNC(dev->path.pci.devfn); const uint32_t f = PCI_FUNC(dev->path.pci.devfn);
printk(BIOS_DEBUG, " [SATC Endpoint Device] " printk(BIOS_DEBUG, " [SATC Endpoint Device] %s\n", dev_path(dev));
"Enumeration ID: 0x%x, PCI Bus Number: 0x%x, "
" PCI Path: 0x%x, 0x%x\n", 0, b, d, f);
current += acpi_create_dmar_ds_pci(current, b, d, f); current += acpi_create_dmar_ds_pci(current, b, d, f);
} }
} }