From 6a6f7f8db01a366c98246f5847f58a266d0f7f10 Mon Sep 17 00:00:00 2001 From: Tim Crawford Date: Fri, 5 Apr 2024 11:46:57 -0600 Subject: [PATCH] mb/system76: Update CMOS layouts Use the default position for ramtop and exclude it from the checksum. Fixes invalid checksum after caching ramtop causing things like disabling CSME to not work. Change-Id: Ic7e0cac479e88b0c2645511e5ba4fd9622573a17 Signed-off-by: Tim Crawford --- src/mainboard/system76/addw1/cmos.layout | 7 +++++-- src/mainboard/system76/adl/cmos.layout | 7 +++++-- src/mainboard/system76/bonw14/cmos.layout | 7 +++++-- src/mainboard/system76/cml-u/cmos.layout | 7 +++++-- src/mainboard/system76/gaze15/cmos.layout | 7 +++++-- src/mainboard/system76/kbl-u/cmos.layout | 7 +++++-- src/mainboard/system76/mtl/cmos.layout | 7 +++++-- src/mainboard/system76/oryp5/cmos.layout | 7 +++++-- src/mainboard/system76/oryp6/cmos.layout | 7 +++++-- src/mainboard/system76/rpl/cmos.layout | 7 +++++-- src/mainboard/system76/tgl-h/cmos.layout | 7 +++++-- src/mainboard/system76/tgl-u/cmos.layout | 7 +++++-- src/mainboard/system76/whl-u/cmos.layout | 7 +++++-- 13 files changed, 65 insertions(+), 26 deletions(-) diff --git a/src/mainboard/system76/addw1/cmos.layout b/src/mainboard/system76/addw1/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/addw1/cmos.layout +++ b/src/mainboard/system76/addw1/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/adl/cmos.layout b/src/mainboard/system76/adl/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/adl/cmos.layout +++ b/src/mainboard/system76/adl/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/bonw14/cmos.layout b/src/mainboard/system76/bonw14/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/bonw14/cmos.layout +++ b/src/mainboard/system76/bonw14/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/cml-u/cmos.layout b/src/mainboard/system76/cml-u/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/cml-u/cmos.layout +++ b/src/mainboard/system76/cml-u/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/gaze15/cmos.layout b/src/mainboard/system76/gaze15/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/gaze15/cmos.layout +++ b/src/mainboard/system76/gaze15/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/kbl-u/cmos.layout b/src/mainboard/system76/kbl-u/cmos.layout index 4e9a300ebf..7aec087ea3 100644 --- a/src/mainboard/system76/kbl-u/cmos.layout +++ b/src/mainboard/system76/kbl-u/cmos.layout @@ -12,7 +12,10 @@ entries 400 8 r 0 century 412 4 e 6 debug_level -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -32,4 +35,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/mtl/cmos.layout b/src/mainboard/system76/mtl/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/mtl/cmos.layout +++ b/src/mainboard/system76/mtl/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/oryp5/cmos.layout b/src/mainboard/system76/oryp5/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/oryp5/cmos.layout +++ b/src/mainboard/system76/oryp5/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/oryp6/cmos.layout b/src/mainboard/system76/oryp6/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/oryp6/cmos.layout +++ b/src/mainboard/system76/oryp6/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/rpl/cmos.layout b/src/mainboard/system76/rpl/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/rpl/cmos.layout +++ b/src/mainboard/system76/rpl/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/tgl-h/cmos.layout b/src/mainboard/system76/tgl-h/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/tgl-h/cmos.layout +++ b/src/mainboard/system76/tgl-h/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/tgl-u/cmos.layout b/src/mainboard/system76/tgl-u/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/tgl-u/cmos.layout +++ b/src/mainboard/system76/tgl-u/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984 diff --git a/src/mainboard/system76/whl-u/cmos.layout b/src/mainboard/system76/whl-u/cmos.layout index 0513315c33..b3df3808cc 100644 --- a/src/mainboard/system76/whl-u/cmos.layout +++ b/src/mainboard/system76/whl-u/cmos.layout @@ -14,7 +14,10 @@ entries 412 4 e 6 debug_level 416 1 e 2 me_state 417 3 h 0 me_state_counter -904 80 h 0 ramtop + +# CMOS_VSTART_ramtop +800 80 r 0 ramtop + 984 16 h 0 check_sum enumerations @@ -37,4 +40,4 @@ enumerations checksums -checksum 408 983 984 +checksum 408 799 984