sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/(device/lib/soc): Remove unused variables

Browse Source 
When building grunt with flags set to detect variables that get a value but
then are unused, there are 5 instances that causes error (unused variable).
In most cases it's enough to simply remove the variable. Other instances,
is better to simply use the variables (one instance it's a return value, on
the other instance using the variables makes code more readable).

BUG=b:120260448
TEST=Build and boot grunt.

Change-Id: I0d00fb6a42db20afb34c76b9445a741a57096ead
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/c/29985
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Richard Spiegel
2018-11-30 10:53:40 -07:00
committed by Patrick Georgi
parent c3a27dffe9
commit 6a9e6cd89e
4 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/amd/stoneyridge/northbridge.c
View File

@@ -232,9 +232,9 @@ static unsigned long agesa_write_acpi_tables(struct device *device,
/* HEST */
current = ALIGN(current, 8);
hest = (acpi_hest_t *)current;
acpi_write_hest((void *)current, acpi_fill_hest);
acpi_write_hest(hest, acpi_fill_hest);
acpi_add_table(rsdp, (void *)current);
current += ((acpi_header_t *)current)->length;
current += hest->header.length;
/* BERT */
if (IS_ENABLED(CONFIG_ACPI_BERT) && bert_errors_present()) {
@@ -250,9 +250,9 @@ static unsigned long agesa_write_acpi_tables(struct device *device,
} else {
current = ALIGN(current, 8);
bert = (acpi_bert_t *)current;
acpi_write_bert((void *)current, (uintptr_t)rgn, size);
acpi_write_bert(bert, (uintptr_t)rgn, size);
acpi_add_table(rsdp, (void *)current);
current += ((acpi_header_t *)current)->length;
current += bert->header.length;
}
}