sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/early_smbus: Drop unused function parameter

Browse Source 
Change-Id: I2d62c470c5389af3b10e47ca5e721b78ff16bc79
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38051
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Kyösti Mälkki
2020-01-01 18:11:24 +02:00
parent 22d2604c46
commit 6af55e583d
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/device/early_smbus.h
View File

@ -49,8 +49,8 @@
#include <stdint.h> #include <stdint.h>
u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset); u16 smbus_read_word(u8 addr, u8 offset);
u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_read_byte(u8 addr, u8 offset);
u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value); u8 smbus_write_byte(u8 addr, u8 offset, u8 value);
#endif /* DEVICE_EARLY_SMBUS_H */ #endif /* DEVICE_EARLY_SMBUS_H */

10
src/lib/spd_bin.c
View File

@ -227,15 +227,15 @@ static void smbus_read_spd(u8 *spd, u8 addr)
for (i = 0; i < SPD_PAGE_LEN; i += step) { for (i = 0; i < SPD_PAGE_LEN; i += step) {
if (CONFIG(SPD_READ_BY_WORD)) if (CONFIG(SPD_READ_BY_WORD))
((u16*)spd)[i / sizeof(uint16_t)] = ((u16*)spd)[i / sizeof(uint16_t)] =
smbus_read_word(0, addr, i); smbus_read_word(addr, i);
else else
spd[i] = smbus_read_byte(0, addr, i); spd[i] = smbus_read_byte(addr, i);
} }
} }
static void get_spd(u8 *spd, u8 addr) static void get_spd(u8 *spd, u8 addr)
{ {
if (smbus_read_byte(0, addr, 0) == 0xff) { if (smbus_read_byte(addr, 0) == 0xff) {
printk(BIOS_INFO, "No memory dimm at address %02X\n", printk(BIOS_INFO, "No memory dimm at address %02X\n",
addr << 1); addr << 1);
/* Make sure spd is zeroed if dimm doesn't exist. */ /* Make sure spd is zeroed if dimm doesn't exist. */
@ -248,10 +248,10 @@ static void get_spd(u8 *spd, u8 addr)
if (spd[SPD_DRAM_TYPE] == SPD_DRAM_DDR4 && if (spd[SPD_DRAM_TYPE] == SPD_DRAM_DDR4 &&
CONFIG_DIMM_SPD_SIZE > SPD_PAGE_LEN) { CONFIG_DIMM_SPD_SIZE > SPD_PAGE_LEN) {
/* Switch to page 1 */ /* Switch to page 1 */
smbus_write_byte(0, SPD_PAGE_1, 0, 0); smbus_write_byte(SPD_PAGE_1, 0, 0);
smbus_read_spd(spd + SPD_PAGE_LEN, addr); smbus_read_spd(spd + SPD_PAGE_LEN, addr);
/* Restore to page 0 */ /* Restore to page 0 */
smbus_write_byte(0, SPD_PAGE_0, 0, 0); smbus_write_byte(SPD_PAGE_0, 0, 0);
} }
} }

6
src/soc/intel/common/block/smbus/smbuslib.c
View File

@ -178,17 +178,17 @@ int smbus_read16(unsigned int smbus_base, unsigned int device,
return data; return data;
} }
u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset) u16 smbus_read_word(u8 addr, u8 offset)
{ {
return smbus_read16(SMBUS_IO_BASE, addr, offset); return smbus_read16(SMBUS_IO_BASE, addr, offset);
} }
u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset) u8 smbus_read_byte(u8 addr, u8 offset)
{ {
return smbus_read8(SMBUS_IO_BASE, addr, offset); return smbus_read8(SMBUS_IO_BASE, addr, offset);
} }
u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value) u8 smbus_write_byte(u8 addr, u8 offset, u8 value)
{ {
return smbus_write8(SMBUS_IO_BASE, addr, offset, value); return smbus_write8(SMBUS_IO_BASE, addr, offset, value);
} }