sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/*/include/msr: drop _LO part from PSTATE definition names

Browse Source 
The _LO part in the definition names is a leftover from before moving to
the pstate_msr union access to the bitfield elements where it still
mattered if a bit was in the lower of higher half of the MSR. With the
mask-and-shift access to the two parts of the MSR being gone, the _LO
part in the name isn't useful any more and possibly a bit misleading, so
drop that part.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ib43c71e946388c944ecf40659d4c12ca02a27a5d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73927
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held
2023-03-23 01:28:28 +01:00
parent 5630506fc9
commit 6ba67ab2db
10 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/amd/cezanne/acpi.c
View File

@@ -108,12 +108,12 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (core_freq_div == 0) { if (core_freq_div == 0) {
return 0; return 0;
} else if ((core_freq_div >= PSTATE_DEF_LO_FREQ_DIV_MIN) } else if ((core_freq_div >= PSTATE_DEF_FREQ_DIV_MIN)
&& (core_freq_div <= PSTATE_DEF_LO_EIGHTH_STEP_MAX)) { && (core_freq_div <= PSTATE_DEF_EIGHTH_STEP_MAX)) {
/* Allow 1/8 integer steps for this range */ /* Allow 1/8 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else if ((core_freq_div > PSTATE_DEF_LO_EIGHTH_STEP_MAX) } else if ((core_freq_div > PSTATE_DEF_EIGHTH_STEP_MAX)
&& (core_freq_div <= PSTATE_DEF_LO_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) { && (core_freq_div <= PSTATE_DEF_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) {
/* Only allow 1/4 integer steps for this range */ /* Only allow 1/4 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else { } else {
@@ -123,11 +123,11 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (valid_freq_divisor) { if (valid_freq_divisor) {
/* 25 * core_freq_mul / (core_freq_div / 8) */ /* 25 * core_freq_mul / (core_freq_div / 8) */
core_freq = core_freq =
((PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div)); ((PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div));
} else { } else {
printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n", printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n",
core_freq_div); core_freq_div);
core_freq = (PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul); core_freq = (PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul);
} }
return core_freq; return core_freq;
} }

8
src/soc/amd/cezanne/include/soc/msr.h
View File

@@ -17,10 +17,10 @@ union pstate_msr {
uint64_t raw; uint64_t raw;
}; };
#define PSTATE_DEF_LO_FREQ_DIV_MIN 0x8 #define PSTATE_DEF_FREQ_DIV_MIN 0x8
#define PSTATE_DEF_LO_EIGHTH_STEP_MAX 0x1A #define PSTATE_DEF_EIGHTH_STEP_MAX 0x1A
#define PSTATE_DEF_LO_FREQ_DIV_MAX 0x3E #define PSTATE_DEF_FREQ_DIV_MAX 0x3E
#define PSTATE_DEF_LO_CORE_FREQ_BASE 25 #define PSTATE_DEF_CORE_FREQ_BASE 25
/* Value defined in Serial VID Interface 2.0 spec (#48022, NDA only) */ /* Value defined in Serial VID Interface 2.0 spec (#48022, NDA only) */
#define SERIAL_VID_DECODE_MICROVOLTS 6250 #define SERIAL_VID_DECODE_MICROVOLTS 6250

2
src/soc/amd/glinda/acpi.c
View File

@@ -106,7 +106,7 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
core_freq_mul = pstate_reg.cpu_fid_0_11; core_freq_mul = pstate_reg.cpu_fid_0_11;
/* CPU frequency is 5 * core_freq_mul */ /* CPU frequency is 5 * core_freq_mul */
return PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul; return PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul;
} }
uint32_t get_pstate_core_power(union pstate_msr pstate_reg) uint32_t get_pstate_core_power(union pstate_msr pstate_reg)

2
src/soc/amd/glinda/include/soc/msr.h
View File

@@ -20,7 +20,7 @@ union pstate_msr {
uint64_t raw; uint64_t raw;
}; };
#define PSTATE_DEF_LO_CORE_FREQ_BASE 5 #define PSTATE_DEF_CORE_FREQ_BASE 5
/* Value defined in Serial VID Interface 3.0 spec (#56413, NDA only) */ /* Value defined in Serial VID Interface 3.0 spec (#56413, NDA only) */
#define SERIAL_VID_DECODE_MICROVOLTS 5000 #define SERIAL_VID_DECODE_MICROVOLTS 5000

12
src/soc/amd/mendocino/acpi.c
View File

@@ -110,12 +110,12 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (core_freq_div == 0) { if (core_freq_div == 0) {
return 0; return 0;
} else if ((core_freq_div >= PSTATE_DEF_LO_FREQ_DIV_MIN) } else if ((core_freq_div >= PSTATE_DEF_FREQ_DIV_MIN)
&& (core_freq_div <= PSTATE_DEF_LO_EIGHTH_STEP_MAX)) { && (core_freq_div <= PSTATE_DEF_EIGHTH_STEP_MAX)) {
/* Allow 1/8 integer steps for this range */ /* Allow 1/8 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else if ((core_freq_div > PSTATE_DEF_LO_EIGHTH_STEP_MAX) } else if ((core_freq_div > PSTATE_DEF_EIGHTH_STEP_MAX)
&& (core_freq_div <= PSTATE_DEF_LO_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) { && (core_freq_div <= PSTATE_DEF_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) {
/* Only allow 1/4 integer steps for this range */ /* Only allow 1/4 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else { } else {
@@ -125,11 +125,11 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (valid_freq_divisor) { if (valid_freq_divisor) {
/* 25 * core_freq_mul / (core_freq_div / 8) */ /* 25 * core_freq_mul / (core_freq_div / 8) */
core_freq = core_freq =
((PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div)); ((PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div));
} else { } else {
printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n", printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n",
core_freq_div); core_freq_div);
core_freq = (PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul); core_freq = (PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul);
} }
return core_freq; return core_freq;
} }

8
src/soc/amd/mendocino/include/soc/msr.h
View File

@@ -17,10 +17,10 @@ union pstate_msr {
uint64_t raw; uint64_t raw;
}; };
#define PSTATE_DEF_LO_FREQ_DIV_MIN 0x8 #define PSTATE_DEF_FREQ_DIV_MIN 0x8
#define PSTATE_DEF_LO_EIGHTH_STEP_MAX 0x1A #define PSTATE_DEF_EIGHTH_STEP_MAX 0x1A
#define PSTATE_DEF_LO_FREQ_DIV_MAX 0x3E #define PSTATE_DEF_FREQ_DIV_MAX 0x3E
#define PSTATE_DEF_LO_CORE_FREQ_BASE 25 #define PSTATE_DEF_CORE_FREQ_BASE 25
/* Value defined in Serial VID Interface 3.0 spec (#56413, NDA only) */ /* Value defined in Serial VID Interface 3.0 spec (#56413, NDA only) */
#define SERIAL_VID_DECODE_MICROVOLTS 5000 #define SERIAL_VID_DECODE_MICROVOLTS 5000

12
src/soc/amd/phoenix/acpi.c
View File

@@ -111,12 +111,12 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (core_freq_div == 0) { if (core_freq_div == 0) {
return 0; return 0;
} else if ((core_freq_div >= PSTATE_DEF_LO_FREQ_DIV_MIN) } else if ((core_freq_div >= PSTATE_DEF_FREQ_DIV_MIN)
&& (core_freq_div <= PSTATE_DEF_LO_EIGHTH_STEP_MAX)) { && (core_freq_div <= PSTATE_DEF_EIGHTH_STEP_MAX)) {
/* Allow 1/8 integer steps for this range */ /* Allow 1/8 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else if ((core_freq_div > PSTATE_DEF_LO_EIGHTH_STEP_MAX) } else if ((core_freq_div > PSTATE_DEF_EIGHTH_STEP_MAX)
&& (core_freq_div <= PSTATE_DEF_LO_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) { && (core_freq_div <= PSTATE_DEF_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) {
/* Only allow 1/4 integer steps for this range */ /* Only allow 1/4 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else { } else {
@@ -126,11 +126,11 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (valid_freq_divisor) { if (valid_freq_divisor) {
/* 25 * core_freq_mul / (core_freq_div / 8) */ /* 25 * core_freq_mul / (core_freq_div / 8) */
core_freq = core_freq =
((PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div)); ((PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div));
} else { } else {
printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n", printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n",
core_freq_div); core_freq_div);
core_freq = (PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul); core_freq = (PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul);
} }
return core_freq; return core_freq;
} }

8
src/soc/amd/phoenix/include/soc/msr.h
View File

@@ -20,10 +20,10 @@ union pstate_msr {
uint64_t raw; uint64_t raw;
}; };
#define PSTATE_DEF_LO_FREQ_DIV_MIN 0x8 #define PSTATE_DEF_FREQ_DIV_MIN 0x8
#define PSTATE_DEF_LO_EIGHTH_STEP_MAX 0x1A #define PSTATE_DEF_EIGHTH_STEP_MAX 0x1A
#define PSTATE_DEF_LO_FREQ_DIV_MAX 0x3E #define PSTATE_DEF_FREQ_DIV_MAX 0x3E
#define PSTATE_DEF_LO_CORE_FREQ_BASE 25 #define PSTATE_DEF_CORE_FREQ_BASE 25
/* Value defined in Serial VID Interface 3.0 spec (#56413, NDA only) */ /* Value defined in Serial VID Interface 3.0 spec (#56413, NDA only) */
#define SERIAL_VID_DECODE_MICROVOLTS 5000 #define SERIAL_VID_DECODE_MICROVOLTS 5000

12
src/soc/amd/picasso/acpi.c
View File

@@ -112,12 +112,12 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (core_freq_div == 0) { if (core_freq_div == 0) {
return 0; return 0;
} else if ((core_freq_div >= PSTATE_DEF_LO_FREQ_DIV_MIN) } else if ((core_freq_div >= PSTATE_DEF_FREQ_DIV_MIN)
&& (core_freq_div <= PSTATE_DEF_LO_EIGHTH_STEP_MAX)) { && (core_freq_div <= PSTATE_DEF_EIGHTH_STEP_MAX)) {
/* Allow 1/8 integer steps for this range */ /* Allow 1/8 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else if ((core_freq_div > PSTATE_DEF_LO_EIGHTH_STEP_MAX) } else if ((core_freq_div > PSTATE_DEF_EIGHTH_STEP_MAX)
&& (core_freq_div <= PSTATE_DEF_LO_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) { && (core_freq_div <= PSTATE_DEF_FREQ_DIV_MAX) && !(core_freq_div & 0x1)) {
/* Only allow 1/4 integer steps for this range */ /* Only allow 1/4 integer steps for this range */
valid_freq_divisor = true; valid_freq_divisor = true;
} else { } else {
@@ -127,11 +127,11 @@ uint32_t get_pstate_core_freq(union pstate_msr pstate_reg)
if (valid_freq_divisor) { if (valid_freq_divisor) {
/* 25 * core_freq_mul / (core_freq_div / 8) */ /* 25 * core_freq_mul / (core_freq_div / 8) */
core_freq = core_freq =
((PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div)); ((PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul * 8) / (core_freq_div));
} else { } else {
printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n", printk(BIOS_WARNING, "Undefined core_freq_div %x used. Force to 1.\n",
core_freq_div); core_freq_div);
core_freq = (PSTATE_DEF_LO_CORE_FREQ_BASE * core_freq_mul); core_freq = (PSTATE_DEF_CORE_FREQ_BASE * core_freq_mul);
} }
return core_freq; return core_freq;
} }

8
src/soc/amd/picasso/include/soc/msr.h
View File

@@ -21,10 +21,10 @@ union pstate_msr {
uint64_t raw; uint64_t raw;
}; };
#define PSTATE_DEF_LO_FREQ_DIV_MIN 0x8 #define PSTATE_DEF_FREQ_DIV_MIN 0x8
#define PSTATE_DEF_LO_EIGHTH_STEP_MAX 0x1A #define PSTATE_DEF_EIGHTH_STEP_MAX 0x1A
#define PSTATE_DEF_LO_FREQ_DIV_MAX 0x3E #define PSTATE_DEF_FREQ_DIV_MAX 0x3E
#define PSTATE_DEF_LO_CORE_FREQ_BASE 25 #define PSTATE_DEF_CORE_FREQ_BASE 25
/* Value defined in Serial VID Interface 2.0 spec (#48022, NDA only) */ /* Value defined in Serial VID Interface 2.0 spec (#48022, NDA only) */
#define SERIAL_VID_DECODE_MICROVOLTS 6250 #define SERIAL_VID_DECODE_MICROVOLTS 6250