From 6bbf6b1ff964b146afc1299b788de8bd33e441f8 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 30 Aug 2023 12:47:59 +0100 Subject: [PATCH] soc/intel/meteorlake: Correctly set Usb4CmMode The ACPI is adjusted based on SOFTWARE_CONNECTION_MANAGER, so set the UPD to match this to avoid the connection type being mismatched. If it's mismatched, the TBT port will timeout. TEST=Boot starbook/rpl and check TBT 4 dock is correctly identified. Signed-off-by: Sean Rhodes Change-Id: I3ab68c01f682723dab39870f0676e59ae3d89add --- src/soc/intel/meteorlake/fsp_params.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index bf1d9d54f1..702820a788 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -442,6 +442,8 @@ static void fill_fsps_tcss_params(FSP_S_CONFIG *s_cfg, if (is_dev_enabled(tcss_port_arr[i])) s_cfg->UsbTcPortEn |= BIT(i); } + + s_cfg->Usb4CmMode = CONFIG(SOFTWARE_CONNECTION_MANAGER); } static void fill_fsps_chipset_lockdown_params(FSP_S_CONFIG *s_cfg,