sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/aoac: make AOAC device number unsigned

Browse Source 
The AOAC device number is never negative, so make it unsigned.

BRANCH=zork

Change-Id: I3e0d15a646f02da5767504471961d5d9f8f28bea
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45308
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held
2020-09-12 01:01:43 +02:00
parent 2617073ee0
commit 6c61b4b3ac
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/soc/amd/picasso/aoac.c
View File

@@ -29,7 +29,7 @@ const static int aoac_devs[] = {
FCH_AOAC_DEV_ESPI, FCH_AOAC_DEV_ESPI,
}; };
void power_on_aoac_device(int dev) void power_on_aoac_device(unsigned int dev)
{ {
uint8_t byte; uint8_t byte;
@@ -41,7 +41,7 @@ void power_on_aoac_device(int dev)
aoac_write8(AOAC_DEV_D3_CTL(dev), byte); aoac_write8(AOAC_DEV_D3_CTL(dev), byte);
} }
void power_off_aoac_device(int dev) void power_off_aoac_device(unsigned int dev)
{ {
uint8_t byte; uint8_t byte;
@@ -51,7 +51,7 @@ void power_off_aoac_device(int dev)
aoac_write8(AOAC_DEV_D3_CTL(dev), byte); aoac_write8(AOAC_DEV_D3_CTL(dev), byte);
} }
bool is_aoac_device_enabled(int dev) bool is_aoac_device_enabled(unsigned int dev)
{ {
uint8_t byte; uint8_t byte;
@@ -63,7 +63,7 @@ bool is_aoac_device_enabled(int dev)
return false; return false;
} }
void wait_for_aoac_enabled(int dev) void wait_for_aoac_enabled(unsigned int dev)
{ {
while (!is_aoac_device_enabled(dev)) while (!is_aoac_device_enabled(dev))
udelay(100); udelay(100);
@@ -71,7 +71,7 @@ void wait_for_aoac_enabled(int dev)
void enable_aoac_devices(void) void enable_aoac_devices(void)
{ {
int i; unsigned int i;
for (i = 0; i < ARRAY_SIZE(aoac_devs); i++) for (i = 0; i < ARRAY_SIZE(aoac_devs); i++)
power_on_aoac_device(aoac_devs[i]); power_on_aoac_device(aoac_devs[i]);

8
src/soc/amd/picasso/include/soc/southbridge.h
View File

@@ -269,10 +269,10 @@ typedef struct aoac_devs {
} __packed aoac_devs_t; } __packed aoac_devs_t;
void enable_aoac_devices(void); void enable_aoac_devices(void);
bool is_aoac_device_enabled(int dev); bool is_aoac_device_enabled(unsigned int dev);
void power_on_aoac_device(int dev); void power_on_aoac_device(unsigned int dev);
void power_off_aoac_device(int dev); void power_off_aoac_device(unsigned int dev);
void wait_for_aoac_enabled(int dev); void wait_for_aoac_enabled(unsigned int dev);
void sb_clk_output_48Mhz(void); void sb_clk_output_48Mhz(void);
void sb_enable(struct device *dev); void sb_enable(struct device *dev);
void southbridge_final(void *chip_info); void southbridge_final(void *chip_info);