haswell: Turn RCBA configuration into a function

Instead of passing around a pointer to an array, just write the relevant
registers directly. Note that intel/baskingridge used spaces to indent
line continuations and had to be replaced with tabs to quell Jenkins.

Change-Id: Ifa06a2ab24da9b8c6aac6480542fa32d04f6d6fe
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43097
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tristan Corrick <tristan@corrick.kiwi>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>

src/southbridge/intel/lynxpoint/early_pch.c

@@ -77,8 +77,7 @@ void __weak mainboard_config_superio(void)
 {
 }
 
-int early_pch_init(const void *gpio_map,
-		   const struct rcba_config_instruction *rcba_config)
+int early_pch_init(const void *gpio_map)
 {
 	int wake_from_s3;
 
@@ -101,7 +100,7 @@ int early_pch_init(const void *gpio_map,
 	(void) RCBA16(OIC);
 
 	/* Mainboard RCBA settings */
-	pch_config_rcba(rcba_config);
+	mainboard_config_rcba();
 
 	RCBA32_OR(FD, PCH_DISABLE_ALWAYS);
 

src/southbridge/intel/lynxpoint/pch.h

@@ -161,10 +161,10 @@ void acpi_create_intel_hpet(acpi_hpet_t * hpet);
 void acpi_create_serialio_ssdt(acpi_header_t *ssdt);
 
 void enable_usb_bar(void);
-int early_pch_init(const void *gpio_map,
-                   const struct rcba_config_instruction *rcba_config);
+int early_pch_init(const void *gpio_map);
 void pch_enable_lpc(void);
 void mainboard_config_superio(void);
+void mainboard_config_rcba(void);
 
 #define MAINBOARD_POWER_OFF	0
 #define MAINBOARD_POWER_ON	1