sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/wifi/generic: Fix is_cnvi function

Browse Source 
dev->ops = &wifi_cnvi_ops need is_cnvi be true. This cause the exclusive
statement so is_cnvi never be true in !DEVTREE_EARLY.

BUG=b:224317408
TEST=no assertion in coreboot.
[EMERG]  ASSERTION ERROR: file 'src/acpi/acpigen_pci.c', line 24

Signed-off-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Change-Id: I1ca6312ce164c43021686b483f6579164614cede
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62784
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Eric Lai
2022-03-14 17:00:39 +08:00
committed by Tim Wawrzynczak
parent 4573ca42e6
commit 6e3d42ab42
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/wifi/generic/generic.c
View File

@@ -43,11 +43,7 @@ struct device_operations wifi_cnvi_ops = {
static bool is_cnvi(const struct device *dev) static bool is_cnvi(const struct device *dev)
{ {
#if !DEVTREE_EARLY
return dev && dev->ops == &wifi_cnvi_ops;
#else
return dev && dev->path.type != DEVICE_PATH_PCI; return dev && dev->path.type != DEVICE_PATH_PCI;
#endif
} }
bool wifi_generic_cnvi_ddr_rfim_enabled(const struct device *dev) bool wifi_generic_cnvi_ddr_rfim_enabled(const struct device *dev)