nb/intel/x4x: Fix issues found by checkpatch.pl
Change-Id: Ie22b8bd5420f8c33df1866410af42ef41ad38362 Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/18694 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Arthur Heymans
committed by
Nico Huber
Nico Huber
parent
98adaf5989
commit
70a1dda927
@ -40,7 +40,7 @@ void x4x_early_init(void)
|
||||
|
||||
/* Setup PMBASE */
|
||||
pci_write_config32(PCI_DEV(0, 0x1f, 0), PMBASE, DEFAULT_PMBASE | 1);
|
||||
pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x44 /* ACPI_CNTL */ , 0x80);
|
||||
pci_write_config8(PCI_DEV(0, 0x1f, 0), ACPI_CNTL, 0x80);
|
||||
|
||||
/* Setup HECIBAR */
|
||||
pci_write_config32(PCI_DEV(0, 3, 0), 0x10, DEFAULT_HECIBAR);
|
||||
@ -116,13 +116,15 @@ static void init_egress(void)
|
||||
EPBAR32(0x20) = reg32;
|
||||
|
||||
/* Wait for table load */
|
||||
while ((EPBAR8(0x26) & (1 << 0)) != 0);
|
||||
while ((EPBAR8(0x26) & (1 << 0)) != 0)
|
||||
;
|
||||
|
||||
/* VC1: enable */
|
||||
EPBAR32(0x20) |= 1 << 31;
|
||||
|
||||
/* Wait for VC1 */
|
||||
while ((EPBAR8(0x26) & (1 << 1)) != 0);
|
||||
while ((EPBAR8(0x26) & (1 << 1)) != 0)
|
||||
;
|
||||
|
||||
printk(BIOS_DEBUG, "Done Egress Port\n");
|
||||
}
|
||||
@ -195,10 +197,12 @@ static void init_dmi(void)
|
||||
RCBA32(0x20) |= 1 << 31;
|
||||
|
||||
/* Wait for VC1 */
|
||||
while ((RCBA8(0x26) & (1 << 1)) != 0);
|
||||
while ((RCBA8(0x26) & (1 << 1)) != 0)
|
||||
;
|
||||
|
||||
/* Wait for table load */
|
||||
while ((RCBA8(0x26) & (1 << 0)) != 0);
|
||||
while ((RCBA8(0x26) & (1 << 0)) != 0)
|
||||
;
|
||||
|
||||
/* ASPM on DMI link */
|
||||
RCBA16(0x1a8) &= ~0x3;
|
||||
@ -209,7 +213,8 @@ static void init_dmi(void)
|
||||
/* Set up VC1 max time */
|
||||
RCBA32(0x1c) = (RCBA32(0x1c) & ~0x7f0000) | 0x120000;
|
||||
|
||||
while ((DMIBAR32(0x26) & (1 << 1)) != 0);
|
||||
while ((DMIBAR32(0x26) & (1 << 1)) != 0)
|
||||
;
|
||||
printk(BIOS_DEBUG, "Done DMI setup\n");
|
||||
|
||||
/* ASPM on DMI */
|
||||
|
||||
@ -376,7 +376,8 @@ static void gma_func0_init(struct device *dev)
|
||||
pci_dev_init(dev);
|
||||
}
|
||||
|
||||
static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device)
|
||||
static void gma_set_subsystem(device_t dev, unsigned int vendor,
|
||||
unsigned int device)
|
||||
{
|
||||
if (!vendor || !device) {
|
||||
pci_write_config32(dev, PCI_SUBSYSTEM_VENDOR_ID,
|
||||
@ -392,9 +393,8 @@ const struct i915_gpu_controller_info *
|
||||
intel_gma_get_controller_info(void)
|
||||
{
|
||||
device_t dev = dev_find_slot(0, PCI_DEVFN(0x2, 0));
|
||||
if (!dev) {
|
||||
if (!dev)
|
||||
return NULL;
|
||||
}
|
||||
struct northbridge_intel_x4x_config *chip = dev->chip_info;
|
||||
return &chip->gfx;
|
||||
}
|
||||
@ -402,9 +402,8 @@ intel_gma_get_controller_info(void)
|
||||
static void gma_ssdt(device_t device)
|
||||
{
|
||||
const struct i915_gpu_controller_info *gfx = intel_gma_get_controller_info();
|
||||
if (!gfx) {
|
||||
if (!gfx)
|
||||
return;
|
||||
}
|
||||
|
||||
drivers_intel_gma_displays_ssdt_generate(gfx);
|
||||
}
|
||||
@ -422,8 +421,7 @@ static struct device_operations gma_func0_ops = {
|
||||
.ops_pci = &gma_pci_ops,
|
||||
};
|
||||
|
||||
static const unsigned short pci_device_ids[] =
|
||||
{
|
||||
static const unsigned short pci_device_ids[] = {
|
||||
0x2e02, /* Eaglelake */
|
||||
0x2e12, /* Q43/Q45 */
|
||||
0x2e22, /* G43/G45 */
|
||||
|
||||
@ -26,6 +26,6 @@
|
||||
#define DEFAULT_HECIBAR 0xfed10000
|
||||
|
||||
#define TPMBASE 0xfed40000
|
||||
#define TPM32(x) *((volatile u32 *)(TPMBASE + x))
|
||||
#define TPM32(x) (*((volatile u32 *)(TPMBASE + (x))))
|
||||
|
||||
#endif /* X4X_IOMAP_H */
|
||||
|
||||
@ -159,12 +159,11 @@ static struct device_operations cpu_bus_ops = {
|
||||
static void enable_dev(device_t dev)
|
||||
{
|
||||
/* Set the operations if it is a special bus type */
|
||||
if (dev->path.type == DEVICE_PATH_DOMAIN) {
|
||||
if (dev->path.type == DEVICE_PATH_DOMAIN)
|
||||
dev->ops = &pci_domain_ops;
|
||||
} else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
|
||||
else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER)
|
||||
dev->ops = &cpu_bus_ops;
|
||||
}
|
||||
}
|
||||
|
||||
static void x4x_init(void *const chip_info)
|
||||
{
|
||||
@ -191,7 +190,8 @@ static void x4x_init(void *const chip_info)
|
||||
for (; fn >= 0; --fn) {
|
||||
const struct device *const d =
|
||||
dev_find_slot(0, PCI_DEVFN(dev, fn));
|
||||
if (!d || d->enabled) continue;
|
||||
if (!d || d->enabled)
|
||||
continue;
|
||||
const u32 deven = pci_read_config32(d0f0, D0F0_DEVEN);
|
||||
pci_write_config32(d0f0, D0F0_DEVEN,
|
||||
deven & ~(1 << (bit_base + fn)));
|
||||
|
||||
@ -55,29 +55,26 @@ static void sdram_read_spds(struct sysinfo *s)
|
||||
if (j == 62)
|
||||
s->dimms[i].card_type = ((u8) status) & 0x1f;
|
||||
}
|
||||
if (status >= 0) {
|
||||
if (status >= 0)
|
||||
hexdump(s->dimms[i].spd_data, 64);
|
||||
}
|
||||
}
|
||||
|
||||
s->spd_type = 0;
|
||||
int fail = 1;
|
||||
FOR_EACH_POPULATED_DIMM(s->dimms, i) {
|
||||
switch ((enum ddrxspd) s->dimms[i].spd_data[2]) {
|
||||
case DDR2SPD:
|
||||
if (s->spd_type == 0) {
|
||||
if (s->spd_type == 0)
|
||||
s->spd_type = DDR2;
|
||||
} else if (s->spd_type == DDR3) {
|
||||
else if (s->spd_type == DDR3)
|
||||
die("DIMM type mismatch\n");
|
||||
}
|
||||
break;
|
||||
case DDR3SPD:
|
||||
default:
|
||||
if (s->spd_type == 0) {
|
||||
if (s->spd_type == 0)
|
||||
s->spd_type = DDR3;
|
||||
} else if (s->spd_type == DDR2) {
|
||||
else if (s->spd_type == DDR2)
|
||||
die("DIMM type mismatch\n");
|
||||
}
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -135,9 +132,8 @@ static void sdram_read_spds(struct sysinfo *s)
|
||||
fail = 0;
|
||||
}
|
||||
}
|
||||
if (fail) {
|
||||
if (fail)
|
||||
die("No memory dimms, halt\n");
|
||||
}
|
||||
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, chan) {
|
||||
FOR_EACH_POPULATED_DIMM_IN_CHANNEL(s->dimms, chan, i) {
|
||||
@ -163,7 +159,8 @@ static void sdram_read_spds(struct sysinfo *s)
|
||||
static u8 msbpos(u8 val) //Reverse
|
||||
{
|
||||
u8 i;
|
||||
for (i = 7; (i >= 0) && ((val & (1 << i)) == 0); i--);
|
||||
for (i = 7; (i >= 0) && ((val & (1 << i)) == 0); i--)
|
||||
;
|
||||
return i;
|
||||
}
|
||||
|
||||
@ -174,26 +171,22 @@ static void mchinfo_ddr2(struct sysinfo *s)
|
||||
printk(BIOS_WARNING, "%d CPU cores\n", s->cores);
|
||||
|
||||
u32 capid = pci_read_config16(PCI_DEV(0, 0, 0), 0xe8);
|
||||
if (!(capid & (1<<(79-64)))) {
|
||||
if (!(capid & (1<<(79-64))))
|
||||
printk(BIOS_WARNING, "iTPM enabled\n");
|
||||
}
|
||||
|
||||
capid = pci_read_config32(PCI_DEV(0, 0, 0), 0xe4);
|
||||
if (!(capid & (1<<(57-32)))) {
|
||||
if (!(capid & (1<<(57-32))))
|
||||
printk(BIOS_WARNING, "ME enabled\n");
|
||||
}
|
||||
|
||||
if (!(capid & (1<<(56-32)))) {
|
||||
if (!(capid & (1<<(56-32))))
|
||||
printk(BIOS_WARNING, "AMT enabled\n");
|
||||
}
|
||||
|
||||
s->max_ddr2_mhz = 800; // All chipsets in x4x support up to 800MHz DDR2
|
||||
printk(BIOS_WARNING, "Capable of DDR2 of %d MHz or lower\n", s->max_ddr2_mhz);
|
||||
|
||||
if (!(capid & (1<<(48-32)))) {
|
||||
if (!(capid & (1<<(48-32))))
|
||||
printk(BIOS_WARNING, "VT-d enabled\n");
|
||||
}
|
||||
}
|
||||
|
||||
static void sdram_detect_ram_speed(struct sysinfo *s)
|
||||
{
|
||||
@ -205,7 +198,8 @@ static void sdram_detect_ram_speed(struct sysinfo *s)
|
||||
u8 freq = 0;
|
||||
|
||||
// spdidx,cycletime @CAS 5 6
|
||||
u8 idx800[7][2] = {{0,0}, {0,0}, {0,0}, {0,0}, {0,0}, {23,0x30}, {9,0x25}};
|
||||
u8 idx800[7][2] = {{0, 0}, {0, 0}, {0, 0}, {0, 0}, {0, 0}, {23, 0x30},
|
||||
{9, 0x25} };
|
||||
int found = 0;
|
||||
|
||||
// Find max FSB speed
|
||||
@ -236,9 +230,8 @@ static void sdram_detect_ram_speed(struct sysinfo *s)
|
||||
FOR_EACH_POPULATED_DIMM(s->dimms, i) {
|
||||
commoncas &= s->dimms[i].cas_latencies;
|
||||
}
|
||||
if (commoncas == 0) {
|
||||
if (commoncas == 0)
|
||||
die("No common CAS among dimms\n");
|
||||
}
|
||||
|
||||
// Working from fastest to slowest,
|
||||
// fast->slow 5@800 6@800 5@667
|
||||
@ -281,29 +274,24 @@ static void sdram_detect_ram_speed(struct sysinfo *s)
|
||||
maxfreq = (s->max_ddr2_mhz == 800) ? MEM_CLOCK_800MHz : MEM_CLOCK_667MHz;
|
||||
maxfreq >>= 3;
|
||||
freq = MEM_CLOCK_1333MHz;
|
||||
if (maxfreq) {
|
||||
if (maxfreq)
|
||||
freq = maxfreq + 2;
|
||||
}
|
||||
if (freq > MEM_CLOCK_1333MHz) {
|
||||
if (freq > MEM_CLOCK_1333MHz)
|
||||
freq = MEM_CLOCK_1333MHz;
|
||||
}
|
||||
|
||||
// Limit DDR speed to FSB speed
|
||||
switch (s->max_fsb) {
|
||||
case FSB_CLOCK_800MHz:
|
||||
if (freq > MEM_CLOCK_800MHz) {
|
||||
if (freq > MEM_CLOCK_800MHz)
|
||||
freq = MEM_CLOCK_800MHz;
|
||||
}
|
||||
break;
|
||||
case FSB_CLOCK_1066MHz:
|
||||
if (freq > MEM_CLOCK_1066MHz) {
|
||||
if (freq > MEM_CLOCK_1066MHz)
|
||||
freq = MEM_CLOCK_1066MHz;
|
||||
}
|
||||
break;
|
||||
case FSB_CLOCK_1333MHz:
|
||||
if (freq > MEM_CLOCK_1333MHz) {
|
||||
if (freq > MEM_CLOCK_1333MHz)
|
||||
freq = MEM_CLOCK_1333MHz;
|
||||
}
|
||||
break;
|
||||
default:
|
||||
die("Invalid FSB\n");
|
||||
|
||||
@ -329,13 +329,12 @@ static void launch_ddr2(struct sysinfo *s)
|
||||
u32 launch2 = 0;
|
||||
u32 launch3 = 0;
|
||||
|
||||
if (s->selected_timings.CAS == 5) {
|
||||
if (s->selected_timings.CAS == 5)
|
||||
launch2 = 0x00220201;
|
||||
} else if (s->selected_timings.CAS == 6) {
|
||||
else if (s->selected_timings.CAS == 6)
|
||||
launch2 = 0x00230302;
|
||||
} else {
|
||||
else
|
||||
die("Unsupported CAS\n");
|
||||
}
|
||||
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, i) {
|
||||
MCHBAR32(0x400*i + 0x220) = launch1;
|
||||
@ -571,14 +570,14 @@ static void timings_ddr2(struct sysinfo *s)
|
||||
twl = s->selected_timings.CAS - 1;
|
||||
|
||||
FOR_EACH_POPULATED_DIMM(s->dimms, i) {
|
||||
if (s->dimms[i].banks == 1) { // 8 banks
|
||||
if (s->dimms[i].banks == 1) {
|
||||
/* 8 banks */
|
||||
trpmod = 1;
|
||||
bankmod = 0;
|
||||
}
|
||||
if (s->dimms[i].page_size == 2048) {
|
||||
if (s->dimms[i].page_size == 2048)
|
||||
pagemod = 1;
|
||||
}
|
||||
}
|
||||
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, i) {
|
||||
MCHBAR8(0x400*i + 0x26f) = MCHBAR8(0x400*i + 0x26f) | 0x3;
|
||||
@ -606,33 +605,29 @@ static void timings_ddr2(struct sysinfo *s)
|
||||
default:
|
||||
case MEM_CLOCK_667MHz:
|
||||
if (reg8) {
|
||||
if (pagemod) {
|
||||
if (pagemod)
|
||||
reg32 |= 16 << 22;
|
||||
} else {
|
||||
else
|
||||
reg32 |= 12 << 22;
|
||||
}
|
||||
} else {
|
||||
if (pagemod) {
|
||||
if (pagemod)
|
||||
reg32 |= 18 << 22;
|
||||
} else {
|
||||
else
|
||||
reg32 |= 14 << 22;
|
||||
}
|
||||
}
|
||||
break;
|
||||
case MEM_CLOCK_800MHz:
|
||||
if (reg8) {
|
||||
if (pagemod) {
|
||||
if (pagemod)
|
||||
reg32 |= 18 << 22;
|
||||
} else {
|
||||
else
|
||||
reg32 |= 14 << 22;
|
||||
}
|
||||
} else {
|
||||
if (pagemod) {
|
||||
if (pagemod)
|
||||
reg32 |= 20 << 22;
|
||||
} else {
|
||||
else
|
||||
reg32 |= 16 << 22;
|
||||
}
|
||||
}
|
||||
break;
|
||||
}
|
||||
}
|
||||
@ -678,19 +673,18 @@ static void timings_ddr2(struct sysinfo *s)
|
||||
MCHBAR32(0x400*i + 0x248) = (MCHBAR32(0x400*i + 0x248) & ~0x0f001f00) |
|
||||
reg32;
|
||||
|
||||
if (twl > 2) {
|
||||
if (twl > 2)
|
||||
flag1 = 1;
|
||||
}
|
||||
if (s->selected_timings.mem_clk >= MEM_CLOCK_800MHz) {
|
||||
|
||||
if (s->selected_timings.mem_clk >= MEM_CLOCK_800MHz)
|
||||
flag2 = 1;
|
||||
}
|
||||
|
||||
reg16 = (u8)(twl - 1 - flag1 - flag2);
|
||||
reg16 |= reg16 << 4;
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_1333MHz) {
|
||||
if (reg16) {
|
||||
if (reg16)
|
||||
reg16--;
|
||||
}
|
||||
}
|
||||
reg16 |= flag1 << 8;
|
||||
reg16 |= flag2 << 9;
|
||||
MCHBAR16(0x400*i + 0x24d) = (MCHBAR16(0x400*i + 0x24d) & ~0x1ff) | reg16;
|
||||
@ -708,11 +702,10 @@ static void timings_ddr2(struct sysinfo *s)
|
||||
reg16 = 0x99;
|
||||
break;
|
||||
case MEM_CLOCK_800MHz:
|
||||
if (s->selected_timings.CAS == 5) {
|
||||
if (s->selected_timings.CAS == 5)
|
||||
reg16 = 0x19a;
|
||||
} else if (s->selected_timings.CAS == 6) {
|
||||
else if (s->selected_timings.CAS == 6)
|
||||
reg16 = 0x9a;
|
||||
}
|
||||
break;
|
||||
}
|
||||
reg16 &= 0x7;
|
||||
@ -807,9 +800,11 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
MCHBAR16(0x400*i + 0x59c) = MCHBAR16(0x400*i + 0x59c) & ~0x3000;
|
||||
|
||||
reg32 = 0;
|
||||
FOR_EACH_RANK_IN_CHANNEL(r) if (!RANK_IS_POPULATED(s->dimms, i, r)) {
|
||||
FOR_EACH_RANK_IN_CHANNEL(r) {
|
||||
if (!RANK_IS_POPULATED(s->dimms, i, r))
|
||||
reg32 |= 0x111 << r;
|
||||
}
|
||||
|
||||
MCHBAR32(0x400*i + 0x59c) = (MCHBAR32(0x400*i + 0x59c) & ~0xfff) | reg32;
|
||||
MCHBAR8(0x400*i + 0x594) = MCHBAR8(0x400*i + 0x594) & ~1;
|
||||
|
||||
@ -931,7 +926,8 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
for (i = 0; i < 16; i++) {
|
||||
MCHBAR8(0x1c8) = (MCHBAR8(0x1c8) & ~0x1f) | i;
|
||||
MCHBAR8(0x180) = MCHBAR8(0x180) | 0x10;
|
||||
while (MCHBAR8(0x180) & 0x10);
|
||||
while (MCHBAR8(0x180) & 0x10)
|
||||
;
|
||||
if (MCHBAR32(0x184) == 0xffffffff) {
|
||||
j++;
|
||||
if (j >= 2)
|
||||
@ -951,7 +947,8 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
for (; i < 16; i++) {
|
||||
MCHBAR8(0x1c8) = (MCHBAR8(0x1c8) & ~0x1f) | i;
|
||||
MCHBAR8(0x180) = MCHBAR8(0x180) | 0x4;
|
||||
while (MCHBAR8(0x180) & 0x10);
|
||||
while (MCHBAR8(0x180) & 0x10)
|
||||
;
|
||||
if (MCHBAR32(0x184) == 0) {
|
||||
i++;
|
||||
break;
|
||||
@ -960,7 +957,8 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
for (; i < 16; i++) {
|
||||
MCHBAR8(0x1c8) = (MCHBAR8(0x1c8) & ~0x1f) | i;
|
||||
MCHBAR8(0x180) = MCHBAR8(0x180) | 0x10;
|
||||
while (MCHBAR8(0x180) & 0x10);
|
||||
while (MCHBAR8(0x180) & 0x10)
|
||||
;
|
||||
if (MCHBAR32(0x184) == 0xffffffff) {
|
||||
j++;
|
||||
if (j >= 2)
|
||||
@ -972,7 +970,8 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
if (j < 2) {
|
||||
MCHBAR8(0x1c8) = MCHBAR8(0x1c8) & ~0x1f;
|
||||
MCHBAR8(0x180) = MCHBAR8(0x180) | 0x10;
|
||||
while (MCHBAR8(0x180) & 0x10);
|
||||
while (MCHBAR8(0x180) & 0x10)
|
||||
;
|
||||
j = 2;
|
||||
}
|
||||
}
|
||||
@ -1002,7 +1001,8 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
i = (i + 10) % 14;
|
||||
MCHBAR8(0x1c8) = (MCHBAR8(0x1c8) & ~0x1f) | i;
|
||||
MCHBAR8(0x180) = MCHBAR8(0x180) | 0x10;
|
||||
while (MCHBAR8(0x180) & 0x10);
|
||||
while (MCHBAR8(0x180) & 0x10)
|
||||
;
|
||||
}
|
||||
|
||||
reg8 = MCHBAR8(0x188) & ~1;
|
||||
@ -1013,19 +1013,17 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
reg8 |= 1;
|
||||
MCHBAR8(0x188) = reg8;
|
||||
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_1333MHz) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_1333MHz)
|
||||
MCHBAR8(0x18c) = MCHBAR8(0x18c) | 1;
|
||||
}
|
||||
|
||||
// Program DQ/DQS dll settings
|
||||
reg32 = 0;
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, i) {
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz)
|
||||
reg32 = 0x06db7777;
|
||||
} else if (s->selected_timings.mem_clk == MEM_CLOCK_800MHz) {
|
||||
else if (s->selected_timings.mem_clk == MEM_CLOCK_800MHz)
|
||||
reg32 = 0x00007777;
|
||||
}
|
||||
MCHBAR32(0x400*i + 0x540 + lane*4) =
|
||||
(MCHBAR32(0x400*i + 0x540 + lane*4) & 0x0fffffff) |
|
||||
reg32;
|
||||
@ -1034,27 +1032,24 @@ static void dll_ddr2(struct sysinfo *s)
|
||||
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, i) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz) {
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
for (lane = 0; lane < 8; lane++)
|
||||
dqsset(i, lane, &dll_setting_667[DQS1+lane][0]);
|
||||
}
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
for (lane = 0; lane < 8; lane++)
|
||||
dqset(i, lane, &dll_setting_667[DQ1+lane][0]);
|
||||
}
|
||||
} else {
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
for (lane = 0; lane < 8; lane++)
|
||||
dqsset(i, lane, &dll_setting_800[DQS1+lane][0]);
|
||||
}
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
for (lane = 0; lane < 8; lane++)
|
||||
dqset(i, lane, &dll_setting_800[DQ1+lane][0]);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
static void rcomp_ddr2(struct sysinfo *s)
|
||||
{
|
||||
u8 i, j, k;
|
||||
u32 x32a[8] = { 0x04040404, 0x06050505, 0x09090807, 0x0D0C0B0A, 0x04040404, 0x08070605, 0x0C0B0A09, 0x100F0E0D };
|
||||
u32 x32a[8] = { 0x04040404, 0x06050505, 0x09090807, 0x0D0C0B0A,
|
||||
0x04040404, 0x08070605, 0x0C0B0A09, 0x100F0E0D };
|
||||
u16 x378[6] = { 0, 0xAAAA, 0x7777, 0x7777, 0x7777, 0x7777 };
|
||||
u32 x382[6] = { 0, 0x02020202, 0x02020202, 0x02020202, 0x04030303, 0x04030303 };
|
||||
u32 x386[6] = { 0, 0x03020202, 0x03020202, 0x03020202, 0x05040404, 0x05040404 };
|
||||
@ -1113,12 +1108,10 @@ static void rcomp_ddr2(struct sysinfo *s)
|
||||
MCHBAR16(0x178) = 0x0135;
|
||||
MCHBAR32(0x130) = (MCHBAR32(0x130) & ~0x7bdffe0) | 0x7a9ffa0;
|
||||
|
||||
if (!CHANNEL_IS_POPULATED(s->dimms, 0)) {
|
||||
if (!CHANNEL_IS_POPULATED(s->dimms, 0))
|
||||
MCHBAR32(0x130) = MCHBAR32(0x130) & ~(1 << 27);
|
||||
}
|
||||
if (!CHANNEL_IS_POPULATED(s->dimms, 1)) {
|
||||
if (!CHANNEL_IS_POPULATED(s->dimms, 1))
|
||||
MCHBAR32(0x130) = MCHBAR32(0x130) & ~(1 << 28);
|
||||
}
|
||||
|
||||
MCHBAR8(0x130) = MCHBAR8(0x130) | 1;
|
||||
}
|
||||
@ -1250,10 +1243,9 @@ static u8 sampledqs(u16 mchloc, u32 addr, u8 hilow, u8 repeat)
|
||||
barrier();
|
||||
strobe = read32((u32 *)addr);
|
||||
barrier();
|
||||
if (((MCHBAR32(mchloc) & 0x40) >> 6) != hilow) {
|
||||
if (((MCHBAR32(mchloc) & 0x40) >> 6) != hilow)
|
||||
dqsmatch = 0;
|
||||
}
|
||||
}
|
||||
return dqsmatch;
|
||||
}
|
||||
|
||||
@ -1277,18 +1269,28 @@ static void rcven_ddr2(struct sysinfo *s)
|
||||
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, ch) {
|
||||
addr = (ch << 29);
|
||||
for (i = 0; !RANK_IS_POPULATED(s->dimms, ch, i); i++) {
|
||||
for (i = 0; !RANK_IS_POPULATED(s->dimms, ch, i); i++)
|
||||
addr += 128*1024*1024;
|
||||
}
|
||||
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
printk(BIOS_DEBUG, "Channel %d, Lane %d addr=0x%08x\n", ch, lane, addr);
|
||||
coarsecommon = (s->selected_timings.CAS - 1);
|
||||
switch (lane) {
|
||||
case 0: case 1: medium = 0; break;
|
||||
case 2: case 3: medium = 1; break;
|
||||
case 4: case 5: medium = 2; break;
|
||||
case 6: case 7: medium = 3; break;
|
||||
default: medium = 0; break;
|
||||
case 0: case 1:
|
||||
medium = 0;
|
||||
break;
|
||||
case 2: case 3:
|
||||
medium = 1;
|
||||
break;
|
||||
case 4: case 5:
|
||||
medium = 2;
|
||||
break;
|
||||
case 6: case 7:
|
||||
medium = 3;
|
||||
break;
|
||||
default:
|
||||
medium = 0;
|
||||
break;
|
||||
}
|
||||
mchbar = 0x400*ch + 0x561 + (lane << 2);
|
||||
tap = 0;
|
||||
@ -1378,9 +1380,8 @@ static void rcven_ddr2(struct sysinfo *s)
|
||||
while (sampledqs(mchbar, addr, 1, 1) == 0) {
|
||||
savetap = tap;
|
||||
tap++;
|
||||
if (tap > 14) {
|
||||
if (tap > 14)
|
||||
break;
|
||||
}
|
||||
MCHBAR8(0x400*ch + 0x560 + (lane*4)) =
|
||||
(MCHBAR8(0x400*ch + 0x560 + (lane*4)) & ~0xf) | tap;
|
||||
}
|
||||
@ -1402,9 +1403,8 @@ static void rcven_ddr2(struct sysinfo *s)
|
||||
MCHBAR16(0x400*ch + 0x58c) = (MCHBAR16(0x400*ch + 0x58c) &
|
||||
~(3 << (lane*2))) | (medium << (lane*2));
|
||||
}
|
||||
if (sampledqs(mchbar, addr, 1, 1) == 0) {
|
||||
if (sampledqs(mchbar, addr, 1, 1) == 0)
|
||||
die("Not at DQS high, doh\n");
|
||||
}
|
||||
|
||||
printk(BIOS_DEBUG, "rcven 0.4\n");
|
||||
while (sampledqs(mchbar, addr, 1, 1) == 1) {
|
||||
@ -1451,9 +1451,8 @@ static void rcven_ddr2(struct sysinfo *s)
|
||||
while (sampledqs(mchbar, addr, 1, 1) == 0) {
|
||||
savetap = tap;
|
||||
tap++;
|
||||
if (tap > 14) {
|
||||
if (tap > 14)
|
||||
break;
|
||||
}
|
||||
MCHBAR8(0x400*ch + 0x560 + lane*4) =
|
||||
(MCHBAR8(0x400*ch + 0x560 + lane*4) & ~0xf) | tap;
|
||||
}
|
||||
@ -1472,10 +1471,9 @@ static void rcven_ddr2(struct sysinfo *s)
|
||||
|
||||
// Find minimum coarse value
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
if (mincoarse > lanecoarse[lane]) {
|
||||
if (mincoarse > lanecoarse[lane])
|
||||
mincoarse = lanecoarse[lane];
|
||||
}
|
||||
}
|
||||
|
||||
printk(BIOS_DEBUG, "Found min coarse value = %d\n", mincoarse);
|
||||
|
||||
@ -1619,18 +1617,17 @@ static void dradrb_ddr2(struct sysinfo *s)
|
||||
rankpop0 = 0;
|
||||
rankpop1 = 0;
|
||||
FOR_EACH_POPULATED_RANK(s->dimms, ch, r) {
|
||||
if (((s->dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED) && ((r) < s->dimms[ch<<1].ranks))) {
|
||||
if (s->dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED
|
||||
&& (r) < s->dimms[ch<<1].ranks)
|
||||
i = ch << 1;
|
||||
} else {
|
||||
else
|
||||
i = (ch << 1) + 1;
|
||||
}
|
||||
dra = dratab[s->dimms[i].banks]
|
||||
[s->dimms[i].width]
|
||||
[s->dimms[i].cols-9]
|
||||
[s->dimms[i].rows-12];
|
||||
if (s->dimms[i].banks == 1) {
|
||||
if (s->dimms[i].banks == 1)
|
||||
dra |= 0x80;
|
||||
}
|
||||
if (ch == 0) {
|
||||
c0dra |= dra << (r*8);
|
||||
rankpop0 |= 1 << r;
|
||||
@ -1645,20 +1642,20 @@ static void dradrb_ddr2(struct sysinfo *s)
|
||||
MCHBAR8(0x262) = (MCHBAR8(0x262) & ~0xf0) | ((rankpop0 << 4) & 0xf0);
|
||||
MCHBAR8(0x662) = (MCHBAR8(0x662) & ~0xf0) | ((rankpop1 << 4) & 0xf0);
|
||||
|
||||
if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0) || ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) {
|
||||
if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0) ||
|
||||
ONLY_DIMMB_IS_POPULATED(s->dimms, 0))
|
||||
MCHBAR8(0x260) = MCHBAR8(0x260) | 1;
|
||||
}
|
||||
if (ONLY_DIMMA_IS_POPULATED(s->dimms, 1) || ONLY_DIMMB_IS_POPULATED(s->dimms, 1)) {
|
||||
if (ONLY_DIMMA_IS_POPULATED(s->dimms, 1) ||
|
||||
ONLY_DIMMB_IS_POPULATED(s->dimms, 1))
|
||||
MCHBAR8(0x660) = MCHBAR8(0x660) | 1;
|
||||
}
|
||||
|
||||
// DRB
|
||||
FOR_EACH_POPULATED_RANK(s->dimms, ch, r) {
|
||||
if (((s->dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED) && ((r) < s->dimms[ch<<1].ranks))) {
|
||||
if (s->dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED
|
||||
&& (r) < s->dimms[ch<<1].ranks)
|
||||
i = ch << 1;
|
||||
} else {
|
||||
else
|
||||
i = (ch << 1) + 1;
|
||||
}
|
||||
if (ch == 0) {
|
||||
dra0 = (c0dra >> (8*r)) & 0x7f;
|
||||
c0drb = (u16)(c0drb + drbtab[dra0]);
|
||||
@ -1705,30 +1702,27 @@ static void dradrb_ddr2(struct sysinfo *s)
|
||||
MCHBAR16(0x102) = size0 + size1 - size;
|
||||
|
||||
map = 0;
|
||||
if (size0 == 0) {
|
||||
if (size0 == 0)
|
||||
map = 0;
|
||||
} else if (size1 == 0) {
|
||||
else if (size1 == 0)
|
||||
map |= 0x20;
|
||||
} else {
|
||||
else
|
||||
map |= 0x40;
|
||||
}
|
||||
if (size == 0) {
|
||||
map |= 0x18;
|
||||
}
|
||||
|
||||
if (size0 - ME_UMA_SIZEMB >= size1) {
|
||||
if (size == 0)
|
||||
map |= 0x18;
|
||||
|
||||
if (size0 - ME_UMA_SIZEMB >= size1)
|
||||
map |= 0x4;
|
||||
}
|
||||
MCHBAR8(0x110) = map;
|
||||
MCHBAR16(0x10e) = 0;
|
||||
|
||||
if (size1 != 0) {
|
||||
if (size1 != 0)
|
||||
offset = 0;
|
||||
} else if ((size0 > size1) && ((map & 0x7) == 0x4)) {
|
||||
else if ((size0 > size1) && ((map & 0x7) == 0x4))
|
||||
offset = size/2 + (size0 + size1 - size);
|
||||
} else {
|
||||
else
|
||||
offset = size/2 + ME_UMA_SIZEMB;
|
||||
}
|
||||
MCHBAR16(0x108) = offset;
|
||||
MCHBAR16(0x10a) = size/2;
|
||||
}
|
||||
@ -1857,11 +1851,10 @@ static void power_ddr2(struct sysinfo *s)
|
||||
reg3 = 0x232;
|
||||
reg4 = 0x2864;
|
||||
|
||||
if (CHANNEL_IS_POPULATED(s->dimms, 0) && CHANNEL_IS_POPULATED(s->dimms, 1)) {
|
||||
if (CHANNEL_IS_POPULATED(s->dimms, 0) && CHANNEL_IS_POPULATED(s->dimms, 1))
|
||||
MCHBAR32(0x14) = 0x0010461f;
|
||||
} else {
|
||||
else
|
||||
MCHBAR32(0x14) = 0x0010691f;
|
||||
}
|
||||
MCHBAR32(0x18) = 0xdf6437f7;
|
||||
MCHBAR32(0x1c) = 0x0;
|
||||
MCHBAR32(0x24) = (MCHBAR32(0x24) & ~0xe0000000) | 0x30000000;
|
||||
@ -1907,22 +1900,20 @@ static void power_ddr2(struct sysinfo *s)
|
||||
MCHBAR32(0xfbc) = (MCHBAR32(0xfbc) & ~0x7f800) | 0xf000;
|
||||
MCHBAR32(0x1104) = 0x3003232;
|
||||
MCHBAR32(0x1108) = 0x74;
|
||||
if (s->selected_timings.fsb_clk == FSB_CLOCK_800MHz) {
|
||||
if (s->selected_timings.fsb_clk == FSB_CLOCK_800MHz)
|
||||
MCHBAR32(0x110c) = 0xaa;
|
||||
} else {
|
||||
else
|
||||
MCHBAR32(0x110c) = 0x100;
|
||||
}
|
||||
MCHBAR32(0x1110) = 0x10810350 & ~0x78;
|
||||
MCHBAR32(0x1114) = 0;
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz)
|
||||
twl = 5;
|
||||
} else {
|
||||
else
|
||||
twl = 6;
|
||||
}
|
||||
x592 = 0xff;
|
||||
if (pci_read_config8(PCI_DEV(0,0,0), 0x8) < 3) {
|
||||
if (pci_read_config8(PCI_DEV(0, 0, 0), 0x8) < 3)
|
||||
x592 = ~0x4;
|
||||
}
|
||||
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, ch) {
|
||||
MCHBAR8(0x400*ch + 0x239) = twl + 15;
|
||||
MCHBAR16(0x400*ch + 0x23c) = x23c;
|
||||
@ -1933,10 +1924,9 @@ static void power_ddr2(struct sysinfo *s)
|
||||
MCHBAR8(0x400*ch + 0x593) = (MCHBAR8(0x400*ch + 0x593) & ~0x1f) | 0x1e;
|
||||
}
|
||||
|
||||
for (lane = 0; lane < 8; lane++) {
|
||||
for (lane = 0; lane < 8; lane++)
|
||||
MCHBAR8(0x561 + (lane << 2)) = MCHBAR8(0x561 + (lane << 2)) & ~(1 << 3);
|
||||
}
|
||||
}
|
||||
|
||||
void raminit_ddr2(struct sysinfo *s)
|
||||
{
|
||||
@ -1971,7 +1961,7 @@ void raminit_ddr2(struct sysinfo *s)
|
||||
die("Error: DDR is faster than FSB, halt\n");
|
||||
}
|
||||
|
||||
udelay(250000);
|
||||
mdelay(250);
|
||||
|
||||
// Program clock crossing
|
||||
clkcross_ddr2(s);
|
||||
@ -2065,11 +2055,10 @@ void raminit_ddr2(struct sysinfo *s)
|
||||
// After JEDEC reset
|
||||
MCHBAR8(0x40) = MCHBAR8(0x40) & ~0x2;
|
||||
FOR_EACH_POPULATED_CHANNEL(s->dimms, ch) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz) {
|
||||
if (s->selected_timings.mem_clk == MEM_CLOCK_667MHz)
|
||||
reg32 = (2 << 18) | (3 << 13) | (5 << 8);
|
||||
} else {
|
||||
else
|
||||
reg32 = (2 << 18) | (3 << 13) | (4 << 8);
|
||||
}
|
||||
MCHBAR32(0x400*ch + 0x274) = (MCHBAR32(0x400*ch + 0x274) & ~0xfff00) | reg32;
|
||||
MCHBAR8(0x400*ch + 0x274) = MCHBAR8(0x400*ch + 0x274) & ~0x80;
|
||||
MCHBAR8(0x400*ch + 0x26c) = MCHBAR8(0x400*ch + 0x26c) | 1;
|
||||
|
||||
@ -82,9 +82,9 @@
|
||||
* MCHBAR
|
||||
*/
|
||||
|
||||
#define MCHBAR8(x) *((volatile u8 *)(DEFAULT_MCHBAR + x))
|
||||
#define MCHBAR16(x) *((volatile u16 *)(DEFAULT_MCHBAR + x))
|
||||
#define MCHBAR32(x) *((volatile u32 *)(DEFAULT_MCHBAR + x))
|
||||
#define MCHBAR8(x) (*((volatile u8 *)(DEFAULT_MCHBAR + (x))))
|
||||
#define MCHBAR16(x) (*((volatile u16 *)(DEFAULT_MCHBAR + (x))))
|
||||
#define MCHBAR32(x) (*((volatile u32 *)(DEFAULT_MCHBAR + (x))))
|
||||
|
||||
#define PMSTS_MCHBAR 0x0f14 /* Self refresh channel status */
|
||||
#define PMSTS_WARM_RESET (1 << 8)
|
||||
@ -103,9 +103,9 @@
|
||||
* DMIBAR
|
||||
*/
|
||||
|
||||
#define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + x))
|
||||
#define DMIBAR16(x) *((volatile u16 *)(DEFAULT_DMIBAR + x))
|
||||
#define DMIBAR32(x) *((volatile u32 *)(DEFAULT_DMIBAR + x))
|
||||
#define DMIBAR8(x) (*((volatile u8 *)(DEFAULT_DMIBAR + (x))))
|
||||
#define DMIBAR16(x) (*((volatile u16 *)(DEFAULT_DMIBAR + (x))))
|
||||
#define DMIBAR32(x) (*((volatile u32 *)(DEFAULT_DMIBAR + (x))))
|
||||
|
||||
#define DMIVC0RCTL 0x14
|
||||
#define DMIVC1RCTL 0x20
|
||||
@ -120,9 +120,9 @@
|
||||
* EPBAR
|
||||
*/
|
||||
|
||||
#define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + x))
|
||||
#define EPBAR16(x) *((volatile u16 *)(DEFAULT_EPBAR + x))
|
||||
#define EPBAR32(x) *((volatile u32 *)(DEFAULT_EPBAR + x))
|
||||
#define EPBAR8(x) (*((volatile u8 *)(DEFAULT_EPBAR + (x))))
|
||||
#define EPBAR16(x) (*((volatile u16 *)(DEFAULT_EPBAR + (x))))
|
||||
#define EPBAR32(x) (*((volatile u32 *)(DEFAULT_EPBAR + (x))))
|
||||
|
||||
#define EPESD 0x44
|
||||
#define EPLE1D 0x50
|
||||
@ -164,9 +164,15 @@
|
||||
for (idx = (ch) << 1; idx < ((ch) << 1) + DIMMS_PER_CHANNEL; ++idx)
|
||||
#define FOR_EACH_POPULATED_DIMM_IN_CHANNEL(dimms, ch, idx) \
|
||||
FOR_EACH_DIMM_IN_CHANNEL(ch, idx) IF_DIMM_POPULATED(dimms, idx)
|
||||
#define CHANNEL_IS_POPULATED(dimms, idx) ((dimms[idx<<1].card_type != RAW_CARD_UNPOPULATED) || (dimms[(idx<<1) + 1].card_type != RAW_CARD_UNPOPULATED))
|
||||
#define CHANNEL_IS_CARDF(dimms, idx) ((dimms[idx<<1].card_type == 0xf) || (dimms[(idx<<1) + 1].card_type == 0xf))
|
||||
#define IF_CHANNEL_POPULATED(dimms, idx) if ((dimms[idx<<1].card_type != RAW_CARD_UNPOPULATED) || (dimms[(idx<<1) + 1].card_type != RAW_CARD_UNPOPULATED))
|
||||
#define CHANNEL_IS_POPULATED(dimms, idx) \
|
||||
((dimms[idx<<1].card_type != RAW_CARD_UNPOPULATED) \
|
||||
|| (dimms[(idx<<1) + 1].card_type != RAW_CARD_UNPOPULATED))
|
||||
#define CHANNEL_IS_CARDF(dimms, idx) \
|
||||
((dimms[idx<<1].card_type == 0xf) \
|
||||
|| (dimms[(idx<<1) + 1].card_type == 0xf))
|
||||
#define IF_CHANNEL_POPULATED(dimms, idx) \
|
||||
if ((dimms[idx<<1].card_type != RAW_CARD_UNPOPULATED) \
|
||||
|| (dimms[(idx<<1) + 1].card_type != RAW_CARD_UNPOPULATED))
|
||||
#define FOR_EACH_CHANNEL(idx) \
|
||||
for (idx = 0; idx < TOTAL_CHANNELS; ++idx)
|
||||
#define FOR_EACH_POPULATED_CHANNEL(dimms, idx) \
|
||||
@ -177,8 +183,10 @@
|
||||
(((dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED) && ((r) < dimms[ch<<1].ranks)) || \
|
||||
((dimms[(ch<<1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch<<1) + 1].ranks + 2))))
|
||||
#define IF_RANK_POPULATED(dimms, ch, r) \
|
||||
if (((dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED) && ((r) < dimms[ch<<1].ranks)) || \
|
||||
((dimms[(ch<<1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch<<1) + 1].ranks + 2))))
|
||||
if (((dimms[ch<<1].card_type != RAW_CARD_UNPOPULATED) \
|
||||
&& ((r) < dimms[ch<<1].ranks)) \
|
||||
|| ((dimms[(ch<<1) + 1].card_type != RAW_CARD_UNPOPULATED) \
|
||||
&& ((r) >= 2) && ((r) < (dimms[(ch<<1) + 1].ranks + 2))))
|
||||
#define FOR_EACH_RANK_IN_CHANNEL(r) \
|
||||
for (r = 0; r < RANKS_PER_CHANNEL; ++r)
|
||||
#define FOR_EACH_POPULATED_RANK_IN_CHANNEL(dimms, ch, r) \
|
||||
|
||||
Reference in New Issue
Block a user