From 711f84d177db1f05054e5524f2492e9881a4eab6 Mon Sep 17 00:00:00 2001 From: Cliff Huang Date: Fri, 14 Jul 2023 17:25:50 -0700 Subject: [PATCH] soc/intel/metorlake: Fix PMC GPIO group assignment Those values need to match with the ones defined in PMC PWRM GPIO CFG register. Signed-off-by: Cliff Huang Change-Id: I8e84df83caab794e2fe7186e89e78343c2b55fd0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76536 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal Reviewed-by: Eric Lai Reviewed-by: Subrata Banik --- src/soc/intel/meteorlake/include/soc/pmc.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/soc/intel/meteorlake/include/soc/pmc.h b/src/soc/intel/meteorlake/include/soc/pmc.h index 9a7aabfb1a..6c40b4a5ee 100644 --- a/src/soc/intel/meteorlake/include/soc/pmc.h +++ b/src/soc/intel/meteorlake/include/soc/pmc.h @@ -118,9 +118,11 @@ extern struct device_operations ioe_pmc_ops; #define PMC_GPP_E 0x3 #define PMC_GPP_H 0x4 #define PMC_GPP_F 0x5 -#define PMC_GPP_S 0x6 -#define PMC_GPP_B 0x7 -#define PMC_GPP_D 0x8 +#define PMC_GPP_VGPIO3 0x6 +#define PMC_GPP_VGPIO 0x7 +#define PMC_GPP_S 0x8 +#define PMC_GPP_B 0x9 +#define PMC_GPP_D 0xa #define GBLRST_CAUSE0 0x1924 #define GBLRST_CAUSE0_THERMTRIP (1 << 5)