sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/*/graphic_init: use sizeof instead of hardcoding edid size

Browse Source 
Change-Id: I2b8c4ef75cca9f9d5251789cda4187a02076b69d
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/16964
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Arthur Heymans
2016-10-10 17:49:00 +02:00
committed by Martin Roth
parent e1f0ac4baa
commit 7141ff3b9f
6 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/northbridge/intel/gm45/gma.c
View File

@@ -99,7 +99,8 @@ static void gma_init_lvds(const struct northbridge_intel_gm45_config *info,
for (i = 0; i <= 0x18; i++)
vga_cr_write(i, cr[i]);
intel_gmbus_read_edid(mmio + GMBUS0, 3, 0x50, edid_data, 128);
intel_gmbus_read_edid(mmio + GMBUS0, 3, 0x50, edid_data,
sizeof(edid_data));
decode_edid(edid_data,
sizeof(edid_data), &edid);
mode = &edid.mode;
@@ -410,7 +411,8 @@ static void gma_init_vga(const struct northbridge_intel_gm45_config *info,
udelay(1);
intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, edid_data, 128);
intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, edid_data,
sizeof(edid_data));
intel_gmbus_stop(mmio + GMBUS0);
decode_edid(edid_data,
sizeof(edid_data), &edid);
@@ -644,7 +646,8 @@ static u8 vga_connected(u8 *mmio)
{
u8 vga_edid[128];
u8 header[8] = {0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00};
intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, vga_edid, 128);
intel_gmbus_read_edid(mmio + GMBUS0, 2, 0x50, vga_edid,
sizeof(vga_edid));
intel_gmbus_stop(mmio + GMBUS0);
for (int i = 0; i < 8; i++) {
if (vga_edid[i] != header[i]) {