sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

global: Fix usage of get_option() to make use of CB_CMOS_ codes

Browse Source 
Do not directly check the return value of get_option, but instead compare
the returned value against a CB_CMOS_ error code, or against CB_SUCCESS.

Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4266
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Alexandru Gagniuc
2013-11-23 19:22:53 -06:00
committed by Stefan Reinauer
parent bcfcfa4473
commit 72dccce0c9
18 changed files with 37 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/console/console.c
View File

@ -24,6 +24,7 @@
#ifndef __PRE_RAM__
#include <string.h>
#include <types.h>
/*
* FIXME: get_option() needs to be abstracted better so that other non-volatile
@ -33,14 +34,15 @@
#if CONFIG_USE_OPTION_TABLE
#include <pc80/mc146818rtc.h>
#else
static inline int get_option(void *dest, const char *name) { return -1; }
static inline enum cb_err get_option(void *dest, const char *name)
{ return CB_CMOS_OTABLE_DISABLED; }
#endif
/* initialize the console */
void console_init(void)
{
struct console_driver *driver;
if(get_option(&console_loglevel, "debug_level"))
if(get_option(&console_loglevel, "debug_level") != CB_SUCCESS)
console_loglevel=CONFIG_DEFAULT_CONSOLE_LOGLEVEL;
for(driver = console_drivers; driver < econsole_drivers; driver++) {