sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

global: Fix usage of get_option() to make use of CB_CMOS_ codes

Browse Source 
Do not directly check the return value of get_option, but instead compare
the returned value against a CB_CMOS_ error code, or against CB_SUCCESS.

Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4266
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Alexandru Gagniuc
2013-11-23 19:22:53 -06:00
committed by Stefan Reinauer
parent bcfcfa4473
commit 72dccce0c9
18 changed files with 37 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ec/lenovo/h8/h8.c
View File

@ -172,14 +172,14 @@ static void h8_enable(device_t dev)
h8_trackpoint_enable(conf->trackpoint_enable);
h8_usb_power_enable(1);
if (!get_option(&val, "volume"))
if (get_option(&val, "volume") == CB_SUCCESS)
ec_write(H8_VOLUME_CONTROL, val);
if (!get_option(&val, "bluetooth"))
if (get_option(&val, "bluetooth") == CB_SUCCESS)
h8_bluetooth_enable(val);
if (!get_option(&val, "first_battery")) {
if (get_option(&val, "first_battery") == CB_SUCCESS) {
tmp = ec_read(H8_CONFIG3);
tmp &= ~(1 << 4);
tmp |= (val & 1)<< 4;

2
src/ec/lenovo/pmh7/pmh7.c
View File

@ -113,7 +113,7 @@ static void enable_dev(device_t dev)
pmh7_backlight_enable(conf->backlight_enable);
pmh7_dock_event_enable(conf->dock_event_enable);
if (!get_option(&val, "touchpad"))
if (get_option(&val, "touchpad") == CB_SUCCESS)
pmh7_touchpad_enable(val);
}