sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

global: Fix usage of get_option() to make use of CB_CMOS_ codes

Browse Source 
Do not directly check the return value of get_option, but instead compare
the returned value against a CB_CMOS_ error code, or against CB_SUCCESS.

Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4266
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Alexandru Gagniuc
2013-11-23 19:22:53 -06:00
committed by Stefan Reinauer
parent bcfcfa4473
commit 72dccce0c9
18 changed files with 37 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/northbridge/intel/i945/gma.c
View File

@@ -94,7 +94,7 @@ static void gma_func1_init(struct device *dev)
pci_write_config32(dev, PCI_COMMAND, reg32 |
PCI_COMMAND_MASTER | PCI_COMMAND_IO);
if (!get_option(&val, "tft_brightness"))
if (get_option(&val, "tft_brightness") == CB_SUCCESS)
pci_write_config8(dev, 0xf4, val);
else
pci_write_config8(dev, 0xf4, 0xff);