sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/acpi/pnp.asl: Fix PNP_READ_DMA/PNP_WRITE_DMA macros

Browse Source 
These macros, broken since day one, should CreateByteField instead
of CreateWordField. Without the fix, any ASLs that try to use it
will fail to compile with a "ResourceTag smaller than Field"
warning.

Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/22066
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Keith Hui
2017-10-16 17:14:25 -04:00
committed by Marc Jones
parent b8d66bb6fd
commit 74d8ed0cb8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/superio/acpi/pnp.asl
View File

@@ -124,7 +124,7 @@
ShiftLeft (One, IRQ_FROM, IRQ_TAG##W)
#define PNP_READ_DMA(DMA_FROM, RESOURCE_TEMPLATE, DMA_TAG) \
CreateWordField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\
CreateByteField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\
ShiftLeft (One, DMA_FROM, DMA_TAG##W)
#define PNP_WRITE_IO(IO_TO, RESOURCE, IO_TAG) \
@@ -137,7 +137,7 @@
Subtract (FindSetLeftBit (IRQ_TAG##W), 1, IRQ_TO)
#define PNP_WRITE_DMA(DMA_TO, RESOURCE, DMA_TAG) \
CreateWordField (RESOURCE, DMA_TAG._DMA, DMA_TAG##W)\
CreateByteField (RESOURCE, DMA_TAG._DMA, DMA_TAG##W)\
Subtract (FindSetLeftBit (DMA_TAG##W), 1, DMA_TO)
#endif