sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

(console,drivers/uart)/Kconfig: Fix dependencies

Browse Source 
The dependencies of CONSOLE_SERIAL and DRIVERS_UART were somehow
backwards. Fix that. Now, CONSOLE_SERIAL depends on DRIVERS_UART,
because it's using its interface. The individual UART drivers
select DRIVERS_UART, because they implement the interface and
depend on the common UART code.

Some guards had to be fixed (using CONSOLE_SERIAL now instead of
DRIVERS_UART). Some other guards that were only about compilation
of units were removed. We want to build test as much as possible,
right?

Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/29572
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Nico Huber
2018-11-11 01:42:17 +01:00
parent 7470c902d8
commit 755db95d1a
24 changed files with 64 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/drivers/uart/Kconfig
View File

@ -1,7 +1,5 @@
config DRIVERS_UART
bool
default y if CONSOLE_SERIAL
default n
config DRIVERS_UART_8250IO
# FIXME: Shouldn't have a prompt, should default to n, and
@ -11,6 +9,7 @@ config DRIVERS_UART_8250IO
default n if DRIVERS_UART_8250MEM || HAVE_UART_SPECIAL
default n if NO_UART_ON_SUPERIO
default y
select DRIVERS_UART
config DRIVERS_UART_8250IO_SKIP_INIT
def_bool n
@ -37,6 +36,7 @@ config UART_OVERRIDE_REFCLK
config DRIVERS_UART_8250MEM
bool
default n
select DRIVERS_UART
config DRIVERS_UART_8250MEM_32
bool
@ -46,6 +46,7 @@ config DRIVERS_UART_8250MEM_32
config HAVE_UART_SPECIAL
bool
default n
select DRIVERS_UART
config DRIVERS_UART_OXPCIE
bool "Oxford OXPCIe952"