sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/amd: Remove error messages on non-matching microcode patches

Browse Source 
Microcode update file contains patches for various processor
revisions, it is not an error to have those.

Change-Id: Ifbca26276b66f17092afe249a2cfc229713a9fec
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/4520
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
This commit is contained in:
Kyösti Mälkki
2013-12-12 06:53:05 +02:00
parent f95bb2d7bb
commit 75b68d8f5b
1 changed files with 1 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/cpu/amd/microcode/microcode.c
View File

@@ -51,32 +51,6 @@ struct microcode {
u8 x86_code_entry[191];
};
static int need_apply_patch(struct microcode *m, u32 equivalent_processor_rev_id)
{
if (m->processor_rev_id != equivalent_processor_rev_id) {
printk(BIOS_ERR, "microcode: rev id (%x) does not match this patch.\n", m->processor_rev_id);
printk(BIOS_ERR, "microcode: Not updated! Fix microcode_updates[] \n");
return 0;
}
if (m->nb_dev_id) {
//look at the device id, if not found return;
//if(m->nb_rev_id != installed_nb_rev_id) return 0;
}
if (m->ht_io_hub_dev_id) {
//look at the device id, if not found return;
//if(m->ht_io_hub_rev_id != installed_ht_io_bub_rev_id) return 0;
}
if (m->x86_code_present) {
//if(!x86_code_execute()) return 0;
}
return 1;
}
void amd_update_microcode(void *microcode_updates, u32 equivalent_processor_rev_id)
{
u32 patch_id, new_patch_id;
@@ -93,7 +67,7 @@ void amd_update_microcode(void *microcode_updates, u32 equivalent_processor_rev_
for(c = microcode_updates; m->date_code; m = (struct microcode *)c) {
if( need_apply_patch(m, equivalent_processor_rev_id) ) {
if (m->processor_rev_id == equivalent_processor_rev_id) {
//apply patch
msr.hi = 0;