sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

net/r8167: do net set bus msater enable

Browse Source 
It's very dangerous to set bus master enable, and more so on
a NIC, where random broadcast packets can end up in memory
in unexpected ways.

If your kernel has trouble with the fact that we do not set
bus master enable, you need to fix your kernel.

Change-Id: If07fde7961ad80125567240cb43db036346bef97
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-on: https://review.coreboot.org/17559
Reviewed-by: Timothy Pearson <tpearson@raptorengineering.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Ronald G. Minnich
2016-11-21 08:19:11 -08:00
parent ebbd12f8bc
commit 76a6586eef
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/drivers/net/r8168.c
View File

@ -45,9 +45,9 @@ static void r8168_init(struct device *dev)
struct resource *nic_res = find_resource(dev, PCI_BASE_ADDRESS_0); struct resource *nic_res = find_resource(dev, PCI_BASE_ADDRESS_0);
u16 nic_port = (u16)nic_res->base; u16 nic_port = (u16)nic_res->base;
/* Set bus master */ /* Ensble but do not set bus master. That's dangerous on a NIC. */
pci_write_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER pci_write_config16(dev, PCI_COMMAND,
| PCI_COMMAND_MEMORY | PCI_COMMAND_IO); PCI_COMMAND_MEMORY | PCI_COMMAND_IO);
/* Reset NIC */ /* Reset NIC */
printk(BIOS_DEBUG, "r8168: Resetting NIC..."); printk(BIOS_DEBUG, "r8168: Resetting NIC...");