sb/lynxpoint/gpio: fix interrupt storm
On newer kernels (> 4.9 LTS), the GPIO ACPI device's interrupt resource causes an interrupt storm which prevents the CPU from properly idling, significantly increasing power consumption. This was fixed for soc/broadwell (which also supports lynxpoint-lp) by removing the interrupt resource, so apply the same fix here. Original fix: https://chromium-review.googlesource.com/203645 Test: build/boot google/wolf, verify CPU0 idles correctly and power consumption drop via powertop in kernels 4.16.18 and 5.x. Change-Id: Ic4963f2f0225b5f44a7604b0107911640345c855 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39578 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
		
				
					committed by
					
						
						Patrick Georgi
					
				
			
			
				
	
			
			
			
						parent
						
							0ae21ff7ff
						
					
				
				
					commit
					7790cb680a
				
			@@ -551,8 +551,9 @@ Device (GPIO)
 | 
				
			|||||||
			,            // ResourceSourceIndex
 | 
								,            // ResourceSourceIndex
 | 
				
			||||||
			,            // ResourceSource
 | 
								,            // ResourceSource
 | 
				
			||||||
			BAR0)
 | 
								BAR0)
 | 
				
			||||||
		Interrupt (ResourceConsumer,
 | 
							// Disabled due to IRQ storm: http://crosbug.com/p/29548
 | 
				
			||||||
			Level, ActiveHigh, Shared, , ,) {14}
 | 
							//Interrupt (ResourceConsumer,
 | 
				
			||||||
 | 
							//	Level, ActiveHigh, Shared, , , ) {14}
 | 
				
			||||||
	})
 | 
						})
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	Method (_CRS, 0, NotSerialized)
 | 
						Method (_CRS, 0, NotSerialized)
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user