sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/brya/var/{redrix, redrix4es}: Fix PLD group order

Browse Source 
In ec/google/chromeec: Add PLD to EC conn in ACPI table
(667471b8d8), PLD is added to ACPI table.

This patch ensures USB _PLD group numbers are appear in order.

BUG=b:216490477
TEST=build coreboot and system boot into OS.

Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I80d9038d1f41d65201d6bfdb808708f997d71faf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62031
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
This commit is contained in:
Subrata Banik
2022-02-16 15:37:52 +05:30
committed by Felix Held
parent 8c83e3f7fd
commit 782d012590
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/brya/variants/redrix/overridetree.cb
View File

@@ -491,7 +491,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_OVAL, .shape = PLD_SHAPE_OVAL,
.group = ACPI_PLD_GROUP(3, 1)}" .group = ACPI_PLD_GROUP(2, 1)}"
device ref tcss_usb3_port3 on end device ref tcss_usb3_port3 on end
end end
end end
@@ -521,7 +521,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_OVAL, .shape = PLD_SHAPE_OVAL,
.group = ACPI_PLD_GROUP(3, 1)}" .group = ACPI_PLD_GROUP(2, 1)}"
device ref usb2_port3 on end device ref usb2_port3 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
@@ -543,7 +543,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_HORIZONTAL_RECTANGLE, .shape = PLD_SHAPE_HORIZONTAL_RECTANGLE,
.group = ACPI_PLD_GROUP(4, 1)}" .group = ACPI_PLD_GROUP(3, 1)}"
device ref usb2_port9 on end device ref usb2_port9 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
@@ -562,7 +562,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_HORIZONTAL_RECTANGLE, .shape = PLD_SHAPE_HORIZONTAL_RECTANGLE,
.group = ACPI_PLD_GROUP(4, 1)}" .group = ACPI_PLD_GROUP(3, 1)}"
device ref usb3_port1 on end device ref usb3_port1 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi

8
src/mainboard/google/brya/variants/redrix4es/overridetree.cb
View File

@@ -477,7 +477,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_OVAL, .shape = PLD_SHAPE_OVAL,
.group = ACPI_PLD_GROUP(3, 1)}" .group = ACPI_PLD_GROUP(2, 1)}"
device ref tcss_usb3_port3 on end device ref tcss_usb3_port3 on end
end end
end end
@@ -507,7 +507,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_OVAL, .shape = PLD_SHAPE_OVAL,
.group = ACPI_PLD_GROUP(3, 1)}" .group = ACPI_PLD_GROUP(2, 1)}"
device ref usb2_port3 on end device ref usb2_port3 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
@@ -529,7 +529,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_HORIZONTAL_RECTANGLE, .shape = PLD_SHAPE_HORIZONTAL_RECTANGLE,
.group = ACPI_PLD_GROUP(4, 1)}" .group = ACPI_PLD_GROUP(3, 1)}"
device ref usb2_port9 on end device ref usb2_port9 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi
@@ -548,7 +548,7 @@ chip soc/intel/alderlake
.panel = PLD_PANEL_RIGHT, .panel = PLD_PANEL_RIGHT,
.horizontal_position = PLD_HORIZONTAL_POSITION_LEFT, .horizontal_position = PLD_HORIZONTAL_POSITION_LEFT,
.shape = PLD_SHAPE_HORIZONTAL_RECTANGLE, .shape = PLD_SHAPE_HORIZONTAL_RECTANGLE,
.group = ACPI_PLD_GROUP(4, 1)}" .group = ACPI_PLD_GROUP(3, 1)}"
device ref usb3_port1 on end device ref usb3_port1 on end
end end
chip drivers/usb/acpi chip drivers/usb/acpi