From 796ea820f2f97546775917b8a80d602bb7361740 Mon Sep 17 00:00:00 2001 From: Derek Huang Date: Wed, 29 Sep 2021 22:05:04 +0800 Subject: [PATCH] ec/google/chromeec: Update google_chromeec_usb_pd_get_info() google_chromeec_usb_pd_get_info() is used in ec.c only. Make it static and drop from ec.h. BUG=b:192947843 Signed-off-by: Derek Huang Change-Id: I4b3df4223d5c26ea1c1a52b26f7d49fa4c947de8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58060 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Furquan Shaikh --- src/ec/google/chromeec/ec.c | 3 ++- src/ec/google/chromeec/ec.h | 3 --- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index e27ad9e938..642c31385a 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1477,7 +1477,8 @@ int google_ec_running_ro(void) return (google_chromeec_get_current_image() == EC_IMAGE_RO); } -int google_chromeec_usb_pd_get_info(int port, bool *ufp, bool *dbg_acc, +/* Returns data role and type of device connected */ +static int google_chromeec_usb_pd_get_info(int port, bool *ufp, bool *dbg_acc, bool *active_cable, uint8_t *dp_mode) { struct ec_params_usb_pd_control pd_control = { diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index f4090fe941..131a46067e 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -33,9 +33,6 @@ void google_chromeec_init(void); * usb capability, dp capability, cable type, etc */ int google_chromeec_usb_get_pd_mux_info(int port, uint8_t *flags); -/* Returns data role and type of device connected */ -int google_chromeec_usb_pd_get_info(int port, bool *ufp, bool *dbg_acc, - bool *active_cable, uint8_t *dp_mode); /* Poll (up to `timeout_ms` ms) for DisplayPort to be ready * Return: -1: Error. 0: Timeout. * >=1: Bitmask of the ports that DP device is connected