cbmem_top_chipset: Change the return value to uintptr_t
Get rid of a lot of casts. Change-Id: I93645ef5dd270905ce421e68e342aff4c331eae6 Signed-off-by: Elyes Haouas <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69078 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jakub Czapiga <jacz@semihalf.com>
This commit is contained in:
@@ -3,14 +3,16 @@
|
||||
// Use simple device model for this file even in ramstage
|
||||
#define __SIMPLE_DEVICE__
|
||||
|
||||
#include <device/pci_ops.h>
|
||||
#include <arch/romstage.h>
|
||||
#include <cbmem.h>
|
||||
#include <cpu/x86/mtrr.h>
|
||||
#include <device/pci_ops.h>
|
||||
#include <program_loading.h>
|
||||
#include <stdint.h>
|
||||
|
||||
#include "e7505.h"
|
||||
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
const pci_devfn_t mch = PCI_DEV(0, 0, 0);
|
||||
uintptr_t tolm;
|
||||
@@ -19,7 +21,7 @@ void *cbmem_top_chipset(void)
|
||||
tolm = pci_read_config16(mch, TOLM) >> 11;
|
||||
tolm <<= 27;
|
||||
|
||||
return (void *)tolm;
|
||||
return tolm;
|
||||
}
|
||||
|
||||
void northbridge_write_smram(u8 smram);
|
||||
|
@@ -104,10 +104,9 @@ static size_t northbridge_get_tseg_size(void)
|
||||
* 1 MiB alignment. As this may cause very greedy MTRR setup, push
|
||||
* CBMEM top downwards to 4 MiB boundary.
|
||||
*/
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
|
||||
return (void *) top_of_ram;
|
||||
return ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
|
||||
}
|
||||
|
||||
void smm_region(uintptr_t *start, size_t *size)
|
||||
|
@@ -54,9 +54,9 @@ static uintptr_t top_of_low_usable_memory(void)
|
||||
return tolum;
|
||||
}
|
||||
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
return (void *)top_of_low_usable_memory();
|
||||
return top_of_low_usable_memory();
|
||||
}
|
||||
|
||||
void smm_region(uintptr_t *start, size_t *size)
|
||||
|
@@ -8,7 +8,7 @@
|
||||
#include <program_loading.h>
|
||||
#include "i440bx.h"
|
||||
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
/* Base of TSEG is top of usable DRAM */
|
||||
/*
|
||||
@@ -39,7 +39,7 @@ void *cbmem_top_chipset(void)
|
||||
*
|
||||
* Source: 440BX datasheet, pages 3-28 thru 3-29.
|
||||
*/
|
||||
unsigned long tom = pci_read_config8(NB, DRB7) * 8 * MiB;
|
||||
uintptr_t tom = pci_read_config8(NB, DRB7) * 8 * MiB;
|
||||
|
||||
int gsmrame = pci_read_config8(NB, SMRAM) & 0x8;
|
||||
/* T_SZ and TSEG_EN */
|
||||
@@ -48,7 +48,7 @@ void *cbmem_top_chipset(void)
|
||||
int tseg_size = 128 * KiB * (1 << (tseg >> 1));
|
||||
tom -= tseg_size;
|
||||
}
|
||||
return (void *)tom;
|
||||
return tom;
|
||||
}
|
||||
|
||||
void fill_postcar_frame(struct postcar_frame *pcf)
|
||||
|
@@ -57,10 +57,9 @@ static size_t northbridge_get_tseg_size(void)
|
||||
* 1 MiB alignment. As this may cause very greedy MTRR setup, push
|
||||
* CBMEM top downwards to 4 MiB boundary.
|
||||
*/
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
|
||||
return (void *) top_of_ram;
|
||||
return ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
|
||||
}
|
||||
|
||||
/* Decodes used Graphics Mode Select (GMS) to kilobytes. */
|
||||
|
@@ -22,9 +22,9 @@ static size_t northbridge_get_tseg_size(void)
|
||||
return CONFIG_SMM_TSEG_SIZE;
|
||||
}
|
||||
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
return (void *)northbridge_get_tseg_base();
|
||||
return northbridge_get_tseg_base();
|
||||
}
|
||||
|
||||
void smm_region(uintptr_t *start, size_t *size)
|
||||
|
@@ -73,9 +73,9 @@ static uintptr_t northbridge_get_tseg_base(void)
|
||||
* Depending of UMA and TSEG configuration, TSEG might start at any 1 MiB alignment.
|
||||
* As this may cause very greedy MTRR setup, push CBMEM top downwards to 4 MiB boundary.
|
||||
*/
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
return (void *) ALIGN_DOWN(northbridge_get_tseg_base(), 4 * MiB);
|
||||
return ALIGN_DOWN(northbridge_get_tseg_base(), 4 * MiB);
|
||||
|
||||
}
|
||||
|
||||
|
@@ -54,9 +54,9 @@ static uintptr_t top_of_low_usable_memory(void)
|
||||
return tolum;
|
||||
}
|
||||
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
return (void *)top_of_low_usable_memory();
|
||||
return top_of_low_usable_memory();
|
||||
}
|
||||
|
||||
void smm_region(uintptr_t *start, size_t *size)
|
||||
|
@@ -71,10 +71,9 @@ static uintptr_t northbridge_get_tseg_base(void)
|
||||
* 1 MiB alignment. As this may cause very greedy MTRR setup, push
|
||||
* CBMEM top downwards to 4 MiB boundary.
|
||||
*/
|
||||
void *cbmem_top_chipset(void)
|
||||
uintptr_t cbmem_top_chipset(void)
|
||||
{
|
||||
uintptr_t top_of_ram = ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
|
||||
return (void *) top_of_ram;
|
||||
return ALIGN_DOWN(northbridge_get_tseg_base(), 4*MiB);
|
||||
}
|
||||
|
||||
void smm_region(uintptr_t *start, size_t *size)
|
||||
|
Reference in New Issue
Block a user