sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard: Drop invalid hyper_threading option

Browse Source 
Drop the `hyper_threading` CMOS option from most boards, as it's most
likely not working properly and causing problems. The main reasons to
remove the option are:

 * The used enum is backwards (0 ---> Enable, 1 ---> Disable)
 * Platform/SoC code does not honor the `hyper_threading` option

Also, remove the now-unused enum used by the `hyper_threading` option.

Change-Id: Ia8980a951f4751bc2e1a5d0e88835f578259b256
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69523
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Angel Pons
2022-11-13 12:48:44 +01:00
committed by Felix Held
parent 4b8ffaee30
commit 7b49c37112
24 changed files with 0 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/asrock/h110m/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

4
src/mainboard/bostentech/gbyt4/cmos.layout
View File

@@ -11,8 +11,6 @@ entries
# ----------------------------------------------------------------- # -----------------------------------------------------------------
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -26,8 +24,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/auron/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -36,8 +33,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/beltino/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -36,8 +33,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

6
src/mainboard/google/butterfly/cmos.layout
View File

@@ -16,10 +16,6 @@ entries
# No serial port on this motherboard # No serial port on this motherboard
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
# hyper_threading not supported by the Celeron 847 on this board
#400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -47,8 +43,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/cyan/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/glados/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/jecht/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/link/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -44,8 +41,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/parrot/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -44,8 +41,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/rambi/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -36,8 +33,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/slippy/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -36,8 +33,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/google/stout/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -44,8 +41,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/intel/baskingridge/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -36,8 +33,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/intel/emeraldlake2/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -44,8 +41,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/intel/kblrvp/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/intel/kunimitsu/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/intel/strago/cmos.layout
View File

@@ -17,9 +17,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -38,8 +35,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

5
src/mainboard/intel/wtm2/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
409 2 e 7 power_on_after_fail 409 2 e 7 power_on_after_fail
@@ -36,8 +33,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

1
src/mainboard/kontron/ktqm77/cmos.layout
View File

@@ -16,7 +16,6 @@ entries
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu # coreboot config options: cpu
400 1 e 2 hyper_threading
401 3 e 12 gfx_uma_size 401 3 e 12 gfx_uma_size
# coreboot config options: southbridge # coreboot config options: southbridge

3
src/mainboard/roda/rv11/cmos.layout
View File

@@ -17,7 +17,6 @@ entries
395 4 e 5 debug_level 395 4 e 5 debug_level
# coreboot config options: cpu # coreboot config options: cpu
400 1 e 2 hyper_threading
401 3 e 9 gfx_uma_size 401 3 e 9 gfx_uma_size
# coreboot config options: southbridge # coreboot config options: southbridge
@@ -46,8 +45,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
3 0 Fallback 3 0 Fallback
3 1 Normal 3 1 Normal
5 0 Emergency 5 0 Emergency

5
src/mainboard/samsung/lumpy/cmos.layout
View File

@@ -15,9 +15,6 @@ entries
# coreboot config options: console # coreboot config options: console
395 4 e 6 debug_level 395 4 e 6 debug_level
# coreboot config options: cpu
400 1 e 2 hyper_threading
# coreboot config options: southbridge # coreboot config options: southbridge
408 1 e 1 nmi 408 1 e 1 nmi
#409 2 e 7 power_on_after_fail #409 2 e 7 power_on_after_fail
@@ -44,8 +41,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency

1
src/mainboard/sapphire/pureplatinumh61/cmos.default
View File

@@ -3,4 +3,3 @@ debug_level=Debug
power_on_after_fail=Enable power_on_after_fail=Enable
nmi=Enable nmi=Enable
sata_mode=AHCI sata_mode=AHCI
hyper_threading=Enable

5
src/mainboard/sapphire/pureplatinumh61/cmos.layout
View File

@@ -21,9 +21,6 @@ entries
421 1 e 9 sata_mode 421 1 e 9 sata_mode
# coreboot config options: cpu
424 1 e 2 hyper_threading
# coreboot config options: northbridge # coreboot config options: northbridge
432 3 e 11 gfx_uma_size 432 3 e 11 gfx_uma_size
@@ -42,8 +39,6 @@ enumerations
#ID value text #ID value text
1 0 Disable 1 0 Disable
1 1 Enable 1 1 Enable
2 0 Enable
2 1 Disable
4 0 Fallback 4 0 Fallback
4 1 Normal 4 1 Normal
6 0 Emergency 6 0 Emergency