util/gitconfig: Use make
in git hooks
As the code was moved from the Makefile.inc to a separate file in
commit 9ab8ae6a
(util/gitconfig: Make gitconfig a bash script),`$(MAKE)`
was replaced by `remake`, introducing dependency on this tool which is
basically a `make` with debugging capabilities. Many developers don't
have `remake` installed, leading to pre-commit hooks being not executed
properly. Apparently this was an unintentional change.
Furthermore, special treatment of `make` tool via the `%MAKE%`
substitution performed during hooks' deployment is still desired. Use
case is calling `remake gitconfig` to set `remake` as the `make` tool in
the hooks. To accomplish this, add a parameter that is passed from the
Makefile.inc to gitconfig.sh.
Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com>
Reviewed-on: https://review.coreboot.org/23096
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
committed by
Martin Roth
parent
687b96155c
commit
7bcd6ecea6
@@ -574,7 +574,7 @@ update:
|
||||
dongle.py -c /dev/term/1 $(obj)/coreboot.rom EOF
|
||||
|
||||
gitconfig:
|
||||
util/gitconfig/gitconfig.sh
|
||||
util/gitconfig/gitconfig.sh "$(MAKE)"
|
||||
|
||||
include util/crossgcc/Makefile.inc
|
||||
|
||||
|
Reference in New Issue
Block a user