soc/amd/picasso: Move sd_emmc_config into emmc_config struct
I plan on adding another eMMC parameter. This refactor keeps the config contained in a single struct. BUG=b:159823235 TEST=Build test Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I4b57d651ab44d6c1cad661d620bffd4207dfebd4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45095 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
committed by
Patrick Georgi
parent
73cd3e704f
commit
7c79d8302b
@@ -112,7 +112,7 @@ static void mainboard_init(void *chip_info)
|
||||
struct soc_amd_picasso_config *cfg = config_of_soc();
|
||||
|
||||
if (!CONFIG(PICASSO_LPC_IOMUX))
|
||||
cfg->sd_emmc_config = SD_EMMC_EMMC_HS400;
|
||||
cfg->emmc_config.timing = SD_EMMC_EMMC_HS400;
|
||||
|
||||
mainboard_program_gpios();
|
||||
|
||||
|
@@ -7,7 +7,9 @@ chip soc/amd/picasso
|
||||
register "fadt_boot_arch" = "ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042"
|
||||
register "fadt_flags" = "ACPI_FADT_SLEEP_BUTTON" # See table 5-34 ACPI 6.3 spec
|
||||
|
||||
register "sd_emmc_config" = "SD_EMMC_DISABLE"
|
||||
register "emmc_config" = "{
|
||||
.timing = SD_EMMC_DISABLE,
|
||||
}"
|
||||
|
||||
register "has_usb2_phy_tune_params" = "1"
|
||||
|
||||
|
@@ -40,7 +40,9 @@ chip soc/amd/picasso
|
||||
|
||||
# End : OPN Performance Configuration
|
||||
|
||||
register "sd_emmc_config" = "SD_EMMC_EMMC_HS400"
|
||||
register "emmc_config" = "{
|
||||
.timing = SD_EMMC_EMMC_HS400,
|
||||
}"
|
||||
|
||||
register "xhci0_force_gen1" = "0"
|
||||
|
||||
|
@@ -40,7 +40,9 @@ chip soc/amd/picasso
|
||||
|
||||
# End : OPN Performance Configuration
|
||||
|
||||
register "sd_emmc_config" = "SD_EMMC_EMMC_HS400"
|
||||
register "emmc_config" = "{
|
||||
.timing = SD_EMMC_EMMC_HS400,
|
||||
}"
|
||||
|
||||
register "xhci0_force_gen1" = "0"
|
||||
|
||||
|
@@ -134,10 +134,10 @@ void variant_devtree_update(void)
|
||||
* So we keep the speed low here, with the intent that
|
||||
* other variants implement these corrections.
|
||||
*/
|
||||
cfg->sd_emmc_config = SD_EMMC_EMMC_HS200;
|
||||
cfg->emmc_config.timing = SD_EMMC_EMMC_HS200;
|
||||
}
|
||||
} else {
|
||||
cfg->sd_emmc_config = SD_EMMC_DISABLE;
|
||||
cfg->emmc_config.timing = SD_EMMC_DISABLE;
|
||||
}
|
||||
|
||||
update_audio_configuration();
|
||||
|
@@ -15,5 +15,5 @@ void variant_devtree_update(void)
|
||||
* Enable eMMC if eMMC bit is set in FW_CONFIG or device is unprovisioned.
|
||||
*/
|
||||
if (!(variant_has_emmc() || boot_is_factory_unprovisioned()))
|
||||
cfg->sd_emmc_config = SD_EMMC_DISABLE;
|
||||
cfg->emmc_config.timing = SD_EMMC_DISABLE;
|
||||
}
|
||||
|
Reference in New Issue
Block a user