From 7d3e57d7a39de2122cbb6102fbc17c3d32e590ef Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 14 Jul 2021 13:18:29 +0530 Subject: [PATCH] soc/intel/tigerlake: Use `is_devfn_enabled()` for Crashlog UPDs Enable FSP Crashlog UPDs if SA_DEVFN_TMT is enabled and SOC_INTEL_CRASHLOG is selected by the SoC user. Change-Id: Ibcd0259da86c8d9853e6cc4983675ac97df46c2d Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/56299 Reviewed-by: Angel Pons Reviewed-by: EricR Lai Tested-by: build bot (Jenkins) --- src/soc/intel/tigerlake/romstage/fsp_params.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/soc/intel/tigerlake/romstage/fsp_params.c b/src/soc/intel/tigerlake/romstage/fsp_params.c index dca84cc725..15a11cdc46 100644 --- a/src/soc/intel/tigerlake/romstage/fsp_params.c +++ b/src/soc/intel/tigerlake/romstage/fsp_params.c @@ -197,10 +197,8 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, m_cfg->TmeEnable = CONFIG(INTEL_TME); /* crashLog config */ - if (CONFIG(SOC_INTEL_CRASHLOG)) { - m_cfg->CpuCrashLogDevice = 1; - m_cfg->CpuCrashLogEnable = 1; - } + m_cfg->CpuCrashLogDevice = CONFIG(SOC_INTEL_CRASHLOG) && is_devfn_enabled(SA_DEVFN_TMT); + m_cfg->CpuCrashLogEnable = m_cfg->CpuCrashLogDevice; } void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version)