mb/clevo/kbl-u: Move memory init config to variant level
Memory init config is board specific. Thus, move it to variant level and hook up variant romstage.c. Change-Id: Id78788815ad9c4ed64f0172fb746ff6e50d608ef Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49132 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
This commit is contained in:
committed by
Michael Niewöhner
parent
8434d92c30
commit
7dc57159fe
@@ -5,6 +5,8 @@ CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include
|
|||||||
bootblock-y += bootblock.c
|
bootblock-y += bootblock.c
|
||||||
bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c
|
bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c
|
||||||
|
|
||||||
|
romstage-y += variants/$(VARIANT_DIR)/romstage.c
|
||||||
|
|
||||||
ramstage-y += ramstage.c
|
ramstage-y += ramstage.c
|
||||||
ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c
|
ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c
|
||||||
ramstage-y += variants/$(VARIANT_DIR)/gpio.c
|
ramstage-y += variants/$(VARIANT_DIR)/gpio.c
|
||||||
|
8
src/mainboard/clevo/kbl-u/include/variant/romstage.h
Normal file
8
src/mainboard/clevo/kbl-u/include/variant/romstage.h
Normal file
@@ -0,0 +1,8 @@
|
|||||||
|
/* SPDX-License-Identifier: GPL-2.0-only */
|
||||||
|
|
||||||
|
#ifndef VARIANT_ROMSTAGE_H
|
||||||
|
#define VARIANT_ROMSTAGE_H
|
||||||
|
|
||||||
|
void variant_configure_fspm(FSPM_UPD *memupd);
|
||||||
|
|
||||||
|
#endif
|
@@ -1,37 +1,9 @@
|
|||||||
/* SPDX-License-Identifier: GPL-2.0-only */
|
/* SPDX-License-Identifier: GPL-2.0-only */
|
||||||
|
|
||||||
#include <soc/romstage.h>
|
#include <soc/romstage.h>
|
||||||
#include <spd_bin.h>
|
#include <variant/romstage.h>
|
||||||
#include <string.h>
|
|
||||||
|
|
||||||
static void mainboard_fill_rcomp_res_data(void *rcomp_ptr)
|
|
||||||
{
|
|
||||||
const u16 RcompResistor[3] = {121, 81, 100};
|
|
||||||
memcpy(rcomp_ptr, RcompResistor, sizeof(RcompResistor));
|
|
||||||
}
|
|
||||||
|
|
||||||
static void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr)
|
|
||||||
{
|
|
||||||
const u16 RcompTarget[5] = {100, 40, 20, 20, 26};
|
|
||||||
memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget));
|
|
||||||
}
|
|
||||||
|
|
||||||
void mainboard_memory_init_params(FSPM_UPD *mupd)
|
void mainboard_memory_init_params(FSPM_UPD *mupd)
|
||||||
{
|
{
|
||||||
FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
|
variant_configure_fspm(mupd);
|
||||||
|
|
||||||
struct spd_block blk = {
|
|
||||||
.addr_map = {0x50, 0x52},
|
|
||||||
};
|
|
||||||
|
|
||||||
get_spd_smbus(&blk);
|
|
||||||
dump_spd_info(&blk);
|
|
||||||
|
|
||||||
mainboard_fill_rcomp_res_data(&mem_cfg->RcompResistor);
|
|
||||||
mainboard_fill_rcomp_strength_data(&mem_cfg->RcompTarget);
|
|
||||||
|
|
||||||
mem_cfg->DqPinsInterleaved = TRUE;
|
|
||||||
mem_cfg->MemorySpdDataLen = blk.len;
|
|
||||||
mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0];
|
|
||||||
mem_cfg->MemorySpdPtr10 = (uintptr_t)blk.spd_array[1];
|
|
||||||
}
|
}
|
||||||
|
38
src/mainboard/clevo/kbl-u/variants/n13xwu/romstage.c
Normal file
38
src/mainboard/clevo/kbl-u/variants/n13xwu/romstage.c
Normal file
@@ -0,0 +1,38 @@
|
|||||||
|
/* SPDX-License-Identifier: GPL-2.0-only */
|
||||||
|
|
||||||
|
#include <fsp/api.h>
|
||||||
|
#include <spd_bin.h>
|
||||||
|
#include <string.h>
|
||||||
|
#include <variant/romstage.h>
|
||||||
|
|
||||||
|
static void mainboard_fill_rcomp_res_data(void *rcomp_ptr)
|
||||||
|
{
|
||||||
|
const u16 RcompResistor[3] = {121, 81, 100};
|
||||||
|
memcpy(rcomp_ptr, RcompResistor, sizeof(RcompResistor));
|
||||||
|
}
|
||||||
|
|
||||||
|
static void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr)
|
||||||
|
{
|
||||||
|
const u16 RcompTarget[5] = {100, 40, 20, 20, 26};
|
||||||
|
memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget));
|
||||||
|
}
|
||||||
|
|
||||||
|
void variant_configure_fspm(FSPM_UPD *mupd)
|
||||||
|
{
|
||||||
|
FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
|
||||||
|
|
||||||
|
struct spd_block blk = {
|
||||||
|
.addr_map = {0x50, 0x52},
|
||||||
|
};
|
||||||
|
|
||||||
|
get_spd_smbus(&blk);
|
||||||
|
dump_spd_info(&blk);
|
||||||
|
|
||||||
|
mainboard_fill_rcomp_res_data(&mem_cfg->RcompResistor);
|
||||||
|
mainboard_fill_rcomp_strength_data(&mem_cfg->RcompTarget);
|
||||||
|
|
||||||
|
mem_cfg->DqPinsInterleaved = TRUE;
|
||||||
|
mem_cfg->MemorySpdDataLen = blk.len;
|
||||||
|
mem_cfg->MemorySpdPtr00 = (uintptr_t)blk.spd_array[0];
|
||||||
|
mem_cfg->MemorySpdPtr10 = (uintptr_t)blk.spd_array[1];
|
||||||
|
}
|
Reference in New Issue
Block a user