sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce warnings/errors in libpayload when using picky compiler options

Browse Source 
The new build system uses quite a few more -W flags for the compiler by
default than the old one. And that's for the better.

Change-Id: Ia8e3d28fb35c56760c2bd0983046c7067e8c5dd6
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/72
Tested-by: build bot (Jenkins)
Reviewed-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Patrick Georgi
2011-04-21 18:57:16 +02:00
committed by Uwe Hermann
parent b3db79e996
commit 7f96583f0f
20 changed files with 50 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
payloads/libpayload/libpci/libpci.c
View File

@ -96,6 +96,8 @@ void pci_filter_init(struct pci_access* pacc, struct pci_filter* pf)
pf->device = -1;
}
static char *invalid_pci_device_string = (char *)"invalid pci device string";
/* parse domain:bus:dev.func (with all components but "dev" optional)
* into filter.
* Returns NULL on success, a string pointer to the error message otherwise.
@ -109,7 +111,7 @@ char *pci_filter_parse_slot(struct pci_filter* filter, const char* id)
char *funcp = strrchr(id, '.');
if (funcp) {
filter->func = strtoul(funcp+1, &endptr, 0);
if (endptr[0] != '\0') return "invalid pci device string";
if (endptr[0] != '\0') return invalid_pci_device_string;
}
char *devp = strrchr(id, ':');
@ -118,7 +120,7 @@ char *pci_filter_parse_slot(struct pci_filter* filter, const char* id)
} else {
filter->dev = strtoul(devp+1, &endptr, 0);
}
if (endptr != funcp) return "invalid pci device string";
if (endptr != funcp) return invalid_pci_device_string;
if (!devp) return NULL;
char *busp = strchr(id, ':');
@ -127,11 +129,11 @@ char *pci_filter_parse_slot(struct pci_filter* filter, const char* id)
} else {
filter->bus = strtoul(busp+1, &endptr, 0);
}
if (endptr != funcp) return "invalid pci device string";
if (endptr != funcp) return invalid_pci_device_string;
if (busp == devp) return NULL;
filter->domain = strtoul(id, &endptr, 0);
if (endptr != busp) return "invalid pci device string";
if (endptr != busp) return invalid_pci_device_string;
return NULL;
}