sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IT8772F: Clean up it8772f includes and add a LED API

Browse Source 
- Remove it8772f c includes
- Add a new LED API, it8772f_gpio_led
- Stumpy: using it8772f_gpio_led

BUG=chrome-os-partner:28232
BRANCH=Guado
TEST=emerge-guado coreboot chromeos-bootimage

Change-Id: I08de52515d3c1e7e85d1761c09a0cebffda7dda3
Signed-off-by: David Wu <David_Wu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/241813
Tested-by: David Wu <david_wu@quantatw.com>
Reviewed-by: Shawn N <shawnn@chromium.org>
Commit-Queue: David Wu <david_wu@quantatw.com>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/12797
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
david
2015-01-19 17:11:36 +08:00
committed by Martin Roth
parent 0fa4f6f23d
commit 80ef7b778e
5 changed files with 58 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/samsung/stumpy/romstage.c
View File

@@ -155,7 +155,10 @@ static void setup_sio_gpios(void)
/*
* GPIO45 as LED_POWER#
*/
it8772f_gpio_setup(DUMMY_DEV, 4, 0x20, 0x20, 0x20, 0x20, 0x20);
it8772f_gpio_led(DUMMY_DEV, 4 /* set */, (0x1<<5) /* select */,
0x00 /* polarity: non-inverting */, 0x00 /* 0=pulldown */,
(0x1<<5) /* output */, (0x1<<5) /* 1=Simple IO function */,
SIO_GPIO_BLINK_GPIO45, IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
/*
* GPIO51 as USBPWRON8#

40
src/mainboard/samsung/stumpy/smihandler.c
View File

@@ -22,44 +22,32 @@
#include <northbridge/intel/sandybridge/sandybridge.h>
#include <cpu/intel/model_206ax/model_206ax.h>
/* FIXME: Include romstage serial for SIO helper functions */
#include <superio/ite/it8772f/early_init.c>
//#include <superio/ite/it8772f/it8772f.h>
/* Include for SIO helper functions */
#include <superio/ite/it8772f/it8772f.h>
#define DUMMY_DEV PNP_DEV(0x2e, 0)
/*
* Change LED_POWER# (SIO GPIO 45) state based on sleep type.
* The IO address is hardcoded as we don't have device path in SMM.
*/
#define SIO_GPIO_BASE_SET4 (0x730 + 3)
#define SIO_GPIO_BLINK_GPIO45 0x25
*/
void mainboard_smi_sleep(u8 slp_typ)
{
u8 reg8;
printk(BIOS_DEBUG, "SMI: sleep S%d\n", slp_typ);
switch (slp_typ) {
case 3:
case 4:
/* Blink LED */
it8772f_enter_conf(DUMMY_DEV);
it8772f_sio_write(DUMMY_DEV, IT8772F_CONFIG_REG_LDN, IT8772F_GPIO);
/* Enable blink pin map */
it8772f_sio_write(DUMMY_DEV, IT8772F_GPIO_LED_BLINK1_PINMAP,
SIO_GPIO_BLINK_GPIO45);
/* Enable 4HZ blink */
it8772f_sio_write(DUMMY_DEV, IT8772F_GPIO_LED_BLINK1_CONTROL, 0x02);
/* Set GPIO to alternate function */
reg8 = it8772f_sio_read(DUMMY_DEV, GPIO_REG_ENABLE(3));
reg8 &= ~(1 << 5);
it8772f_sio_write(DUMMY_DEV, GPIO_REG_ENABLE(3), reg8);
it8772f_exit_conf(DUMMY_DEV);
it8772f_gpio_led(DUMMY_DEV, 4 /* set */, (0x1<<5) /* select */,
(0x1<<5) /* polarity */, (0x1<<5) /* 1=pullup */,
(0x1<<5) /* output */, 0x00, /* 0=Alternate function */
SIO_GPIO_BLINK_GPIO45, IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
break;
case 5:
/* Turn off LED */
reg8 = inb(SIO_GPIO_BASE_SET4);
reg8 |= (1 << 5);
outb(reg8, SIO_GPIO_BASE_SET4);
it8772f_gpio_led(DUMMY_DEV, 4 /* set */, (0x1<<5) /* select */,
0x00 /* polarity: non-inverting */, 0x00 /* 0=pulldown */,
(0x1<<5) /* output */, (0x1<<5) /* 1=Simple IO function */,
SIO_GPIO_BLINK_GPIO45, IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);
break;
default:
break;
}
}