sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/amd: Use DEVICE_NOOP macro over dummy symbol

Browse Source 
Change-Id: I3fdd2a9f981592112998d74ce4cfe4850d8fab31
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7288
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
This commit is contained in:
Edward O'Callaghan
2014-10-31 08:17:23 +11:00
parent 9f74462790
commit 812d2a47d4
10 changed files with 18 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/northbridge/amd/agesa/00730F01/northbridge.c
View File

@@ -1081,10 +1081,6 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_read_resources(device_t dev)
{ {
#if CONFIG_MMCONF_SUPPORT #if CONFIG_MMCONF_SUPPORT
@@ -1108,7 +1104,7 @@ static void cpu_bus_set_resources(device_t dev)
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = cpu_bus_read_resources,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

6
src/northbridge/amd/agesa/family10/northbridge.c
View File

@@ -1376,10 +1376,6 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_read_resources(device_t dev)
{ {
#if CONFIG_MMCONF_SUPPORT #if CONFIG_MMCONF_SUPPORT
@@ -1403,7 +1399,7 @@ static void cpu_bus_set_resources(device_t dev)
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = cpu_bus_read_resources,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

6
src/northbridge/amd/agesa/family15/northbridge.c
View File

@@ -1092,10 +1092,6 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_read_resources(device_t dev)
{ {
} }
@@ -1107,7 +1103,7 @@ static void cpu_bus_set_resources(device_t dev)
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = cpu_bus_read_resources,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

6
src/northbridge/amd/agesa/family15tn/northbridge.c
View File

@@ -1054,10 +1054,6 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_read_resources(device_t dev)
{ {
} }
@@ -1069,7 +1065,7 @@ static void cpu_bus_set_resources(device_t dev)
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = cpu_bus_read_resources,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

6
src/northbridge/amd/agesa/family16kb/northbridge.c
View File

@@ -1060,10 +1060,6 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_read_resources(device_t dev)
{ {
#if CONFIG_MMCONF_SUPPORT #if CONFIG_MMCONF_SUPPORT
@@ -1087,7 +1083,7 @@ static void cpu_bus_set_resources(device_t dev)
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = cpu_bus_read_resources,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

6
src/northbridge/amd/amdfam10/northbridge.c
View File

@@ -1411,10 +1411,6 @@ static void cpu_bus_init(device_t dev)
#endif #endif
} }
static void cpu_bus_noop(device_t dev)
{
}
static void cpu_bus_read_resources(device_t dev) static void cpu_bus_read_resources(device_t dev)
{ {
} }
@@ -1431,7 +1427,7 @@ static void cpu_bus_set_resources(device_t dev)
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_read_resources, .read_resources = cpu_bus_read_resources,
.set_resources = cpu_bus_set_resources, .set_resources = cpu_bus_set_resources,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

10
src/northbridge/amd/amdk8/northbridge.c
View File

@@ -1350,14 +1350,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_noop, .set_resources = DEVICE_NOOP,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = cpu_bus_scan, .scan_bus = cpu_bus_scan,
}; };

10
src/northbridge/amd/gx1/northbridge.c
View File

@@ -132,14 +132,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_noop, .set_resources = DEVICE_NOOP,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = 0, .scan_bus = 0,
}; };

10
src/northbridge/amd/gx2/northbridge.c
View File

@@ -325,14 +325,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_noop, .set_resources = DEVICE_NOOP,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = 0, .scan_bus = 0,
}; };

10
src/northbridge/amd/lx/northbridge.c
View File

@@ -429,14 +429,10 @@ static void cpu_bus_init(device_t dev)
initialize_cpus(dev->link_list); initialize_cpus(dev->link_list);
} }
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = { static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop, .read_resources = DEVICE_NOOP,
.set_resources = cpu_bus_noop, .set_resources = DEVICE_NOOP,
.enable_resources = cpu_bus_noop, .enable_resources = DEVICE_NOOP,
.init = cpu_bus_init, .init = cpu_bus_init,
.scan_bus = 0, .scan_bus = 0,
}; };