From 8171364d064afe5e714e4d6faee3cf44d843eb19 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Sun, 25 Dec 2022 16:54:45 +0100 Subject: [PATCH] tree/acpi: Replace Divide(a,b,c,d) with ASL 2.0 syntax Replace `Divide (a, b, c, d)` with these instructions: c = a % b d = a / b Change-Id: I44366be5b5145a5d19f85df7a2f338866cb9c8b0 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/71515 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Elyes Haouas --- src/ec/hp/kbc1126/acpi/battery.asl | 11 ++++++++--- src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl | 3 ++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/ec/hp/kbc1126/acpi/battery.asl b/src/ec/hp/kbc1126/acpi/battery.asl index 5a5632b92a..e657f4ca6f 100644 --- a/src/ec/hp/kbc1126/acpi/battery.asl +++ b/src/ec/hp/kbc1126/acpi/battery.asl @@ -42,8 +42,12 @@ Mutex (BTMX, 0x00) Method (ITLB, 0, NotSerialized) { - Divide ((NLB1 + 0x09), 0x0A, Local0, Local1) - Divide ((0x96 + 0x09), 0x0A, Local0, Local2) + Local0 = (NLB1 + 9) % 0x0a + Local1 = (NLB1 + 9) / 0x0a + + Local0 = (0x96 + 9) % 0x0a + Local2 = (0x96 + 9) / 0x0a + Local0 = Local0 LB1 = Local1 LB2 = Local2 @@ -229,7 +233,8 @@ Method (\ISTR, 2, Serialized) While (Local1) { Local1-- - Divide (Local0, 10, Local2, Local0) + Local2 = Local0 % 10 + Local0 = Local0 / 10 NUMB[Local1] = Local2 + 48 } ToString (NUMB, Arg1, Local3) diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl index 1f4fb47ba5..1a06314dd4 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl @@ -189,7 +189,8 @@ Method (GBIF, 3, NotSerialized) Local6 = 4 While (Local7) { - Divide (Local7, 10, Local5, Local7) + Local5 = Local7 % 10 + Local7 = Local7 / 10 SERN[Local6] = (Local5 + 0x30) // Add 0x30 to get numeric ASCII Local6-- }