sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: Move skip_atoi function to commonlib

Browse Source 
BUG=none
TEST=Build and verify on Screebo
TEST=make unit-tests

```
$ make tests/commonlib/bsd/string-test
[==========] tests_commonlib_bsd_string-test(tests): Running 1 test(s).
[ RUN      ] test_skip_atoi
[       OK ] test_skip_atoi
[==========] tests_commonlib_bsd_string-test(tests): 1 test(s) run.
[  PASSED  ] 1 test(s).
```

Change-Id: Ifaaa80d0c696a625592ce301f9e3eefb2b4dcd98
Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82910
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Kapil Porwal
2024-06-05 15:52:30 +00:00
committed by Julius Werner
parent 3da7829958
commit 829b94dc98
10 changed files with 74 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/lib/string-test.c
View File

@@ -43,18 +43,6 @@ struct str_with_l_val_t {
{"\t\n\r\f\v-42", -42},
};
/* Used to test skip_atoi */
struct str_with_u_val_t {
char *str;
uint32_t value;
uint32_t offset;
} str_with_u_val[] = {
{"42aa", 42, 2},
{"a", 0, 0},
{"0", 0, 1},
{"4a2", 4, 1},
};
static void test_strdup(void **state)
{
char str[] = "Hello coreboot\n";
@@ -204,19 +192,6 @@ static void test_strncmp(void **state)
assert_int_equal(0, strncmp(str, str2, str2_len - 1));
}
static void test_skip_atoi(void **state)
{
int i;
char *ptr, *copy;
for (i = 0; i < ARRAY_SIZE(str_with_u_val); i++) {
ptr = str_with_u_val[i].str;
copy = ptr;
assert_true(str_with_u_val[i].value == skip_atoi(&ptr));
assert_int_equal(str_with_u_val[i].offset, ptr - copy);
}
}
static void test_strspn(void **state)
{
char str[] = "4213401234";
@@ -260,7 +235,6 @@ int main(void)
cmocka_unit_test(test_strcpy),
cmocka_unit_test(test_strcmp),
cmocka_unit_test(test_strncmp),
cmocka_unit_test(test_skip_atoi),
cmocka_unit_test(test_strspn),
cmocka_unit_test(test_strcspn),
cmocka_unit_test(test_atol),