sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/x86: use ALIGN_UP instead of ALIGN for better readability

Browse Source 
This patch contains the rest of the fixes for this subtree; having one change
for every area would create an unnecessary amouint of patches.

Change-Id: Id92c11d58693292d58cba323c8468db858becfb5
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33630
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held
2019-06-20 14:14:51 +02:00
parent 0f6b51b2de
commit 84b5aa3f50
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/arch/x86/gdt.c
View File

@ -46,7 +46,7 @@ static void move_gdt(int is_recovery)
newgdt = cbmem_find(CBMEM_ID_GDT); newgdt = cbmem_find(CBMEM_ID_GDT);
num_gdt_bytes = (uintptr_t)&gdt_end - (uintptr_t)&gdt; num_gdt_bytes = (uintptr_t)&gdt_end - (uintptr_t)&gdt;
if (!newgdt) { if (!newgdt) {
newgdt = cbmem_add(CBMEM_ID_GDT, ALIGN(num_gdt_bytes, 512)); newgdt = cbmem_add(CBMEM_ID_GDT, ALIGN_UP(num_gdt_bytes, 512));
if (!newgdt) { if (!newgdt) {
printk(BIOS_ERR, "Error: Could not relocate GDT.\n"); printk(BIOS_ERR, "Error: Could not relocate GDT.\n");
return; return;

2
src/arch/x86/include/arch/early_variables.h
View File

@ -69,7 +69,7 @@ int car_active(void);
static inline size_t car_data_size(void) static inline size_t car_data_size(void)
{ {
size_t car_size = _car_relocatable_data_size; size_t car_size = _car_relocatable_data_size;
return ALIGN(car_size, 64); return ALIGN_UP(car_size, 64);
} }
static inline size_t car_object_offset(void *ptr) static inline size_t car_object_offset(void *ptr)

2
src/arch/x86/pirq_routing.c
View File

@ -191,7 +191,7 @@ unsigned long copy_pirq_routing_table(unsigned long addr,
const struct irq_routing_table *routing_table) const struct irq_routing_table *routing_table)
{ {
/* Align the table to be 16 byte aligned. */ /* Align the table to be 16 byte aligned. */
addr = ALIGN(addr, 16); addr = ALIGN_UP(addr, 16);
/* This table must be between 0xf0000 & 0x100000 */ /* This table must be between 0xf0000 & 0x100000 */
printk(BIOS_INFO, "Copying Interrupt Routing Table to 0x%08lx... ", printk(BIOS_INFO, "Copying Interrupt Routing Table to 0x%08lx... ",