sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/alderlake: Use common CAR API for cache reporting

Browse Source 
Replace the SoC-specific `report_cache_info()` function with the
common `car_report_cache_info()` API from `car_lib`. This promotes code
reuse and reduces SoC-specific implementation for cache reporting.

BUG=none
TEST=Builds and boots successfully on google/marasov platform.

Change-Id: I18be2c33dbe5186643af52823eb2fb185a296909
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83481
Reviewed-by: Eric Lai <ericllai@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2024-07-16 13:04:44 +00:00
parent 4c5c685882
commit 84c0d95f3f
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/soc/intel/alderlake/bootblock/report_platform.c
View File

@ -16,6 +16,7 @@
#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
#include <intelblocks/car_lib.h>
#include <soc/bootblock.h>
#include <soc/pci_devs.h>
@ -251,21 +252,6 @@ static inline uint16_t get_dev_id(pci_devfn_t dev)
return pci_read_config16(dev, PCI_DEVICE_ID);
}
static void report_cache_info(void)
{
int cache_level = CACHE_L3;
struct cpu_cache_info info;
if (!fill_cpu_cache_info(cache_level, &info))
return;
printk(BIOS_INFO, "Cache: Level %d: ", cache_level);
printk(BIOS_INFO, "Associativity = %zd Partitions = %zd Line Size = %zd Sets = %zd\n",
info.num_ways, info.physical_partitions, info.line_size, info.num_sets);
printk(BIOS_INFO, "Cache size = %zu MiB\n", get_cache_size(&info)/MiB);
}
static void report_cpu_info(void)
{
u32 i, cpu_id, cpu_feature_flag;
@ -297,7 +283,7 @@ static void report_cpu_info(void)
"CPU: AES %ssupported, TXT %ssupported, VT %ssupported\n",
mode[aes], mode[txt], mode[vt]);
report_cache_info();
car_report_cache_info();
}
static void report_mch_info(void)