sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: Improve test_skip_atoi() in /lib/string-test test case

Browse Source 
Confirm that the pointer is updated to point behind the parsed number.

Signed-off-by: Anna Karas <aka@semihalf.com>
Change-Id: If75a51056229904612c6a9ea20db4182d1935009
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43288
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Anna Karas
2020-07-07 15:34:54 +02:00
committed by Patrick Georgi
parent f7cd0d5a05
commit 86acc04d28
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/lib/string-test.c
View File

@@ -48,11 +48,12 @@ struct str_with_l_val_t {
struct str_with_u_val_t { struct str_with_u_val_t {
char *str; char *str;
uint32_t value; uint32_t value;
uint32_t offset;
} str_with_u_val[] = { } str_with_u_val[] = {
{"42aa", 42}, {"42aa", 42, 2},
{"a", 0}, {"a", 0, 0},
{"0", 0}, {"0", 0, 1},
{"4a2", 4}, {"4a2", 4, 1},
}; };
static void test_strdup(void **state) static void test_strdup(void **state)
@@ -207,11 +208,13 @@ static void test_strncmp(void **state)
static void test_skip_atoi(void **state) static void test_skip_atoi(void **state)
{ {
int i; int i;
char *ptr; char *ptr, *copy;
for (i = 0; i < ARRAY_SIZE(str_with_u_val); i++) { for (i = 0; i < ARRAY_SIZE(str_with_u_val); i++) {
ptr = str_with_u_val[i].str; ptr = str_with_u_val[i].str;
copy = ptr;
assert_true(str_with_u_val[i].value == skip_atoi(&ptr)); assert_true(str_with_u_val[i].value == skip_atoi(&ptr));
assert_int_equal(str_with_u_val[i].offset, ptr - copy);
} }
} }