sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "mb/google/skyrim: Update ASPM settings for the NVMe device"

Browse Source 
This reverts commit 8e1bb93fb8.

Reason: Enabling L.2 breaks some devices on this bridge.  Reverting
until a workaround is found and additional testing is done.

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: I9f721178244e7764e9b08e419db8a8c05ecc29a7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72916
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jon Murphy <jpmurphy@google.com>
This commit is contained in:
Martin Roth
2023-02-08 16:33:44 -07:00
committed by Martin L Roth
parent 72de822ddc
commit 871b47afa5
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/skyrim/port_descriptors.c
View File

@@ -16,6 +16,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.link_speed_capability = GEN3, .link_speed_capability = GEN3,
.turn_off_unused_lanes = true, .turn_off_unused_lanes = true,
.link_aspm = ASPM_L1, .link_aspm = ASPM_L1,
.link_hotplug = 3,
.clk_req = CLK_REQ2, .clk_req = CLK_REQ2,
}, },
{ /* SD */ { /* SD */
@@ -28,6 +29,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.link_speed_capability = GEN3, .link_speed_capability = GEN3,
.turn_off_unused_lanes = true, .turn_off_unused_lanes = true,
.link_aspm = ASPM_L1, .link_aspm = ASPM_L1,
.link_hotplug = 3,
.gpio_group_id = GPIO_27, .gpio_group_id = GPIO_27,
.clk_req = CLK_REQ1, .clk_req = CLK_REQ1,
}, },
@@ -41,7 +43,7 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = {
.link_speed_capability = GEN3, .link_speed_capability = GEN3,
.turn_off_unused_lanes = true, .turn_off_unused_lanes = true,
.link_aspm = ASPM_L1, .link_aspm = ASPM_L1,
.link_aspm_L1_2 = true, .link_hotplug = 3,
.gpio_group_id = GPIO_6, .gpio_group_id = GPIO_6,
.clk_req = CLK_REQ0, .clk_req = CLK_REQ0,
}, },