From 87d95117419a85c522951fe160390ac66ac5fab0 Mon Sep 17 00:00:00 2001 From: Leo Chou Date: Wed, 7 Aug 2024 14:12:31 +0800 Subject: [PATCH] mb/google/nissa/var/pujjoga: Modify P sensor setting 1. The P sensor need follow WWAN FW_CONFIG to enable/disable 2. Modify GPP_H19 setting to PAD_CFG_GPI_APIC to fix PLT test fail Schematic version: 500E_GEN4S_ADL_N_MB_0418 BUG=b:357998089 TEST=1. Boot to OS and verify the P sensor devices is set based on fw_config. 2. Confirm that the PLT test can pass successfully. Change-Id: Ic3610180c8cf99eba9367e26bfc3666410af19f7 Signed-off-by: Leo Chou Reviewed-on: https://review.coreboot.org/c/coreboot/+/83794 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/mainboard/google/brya/variants/pujjoga/gpio.c | 4 ++-- src/mainboard/google/brya/variants/pujjoga/overridetree.cb | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/brya/variants/pujjoga/gpio.c b/src/mainboard/google/brya/variants/pujjoga/gpio.c index cf5c9bdc0d..2950605d4e 100644 --- a/src/mainboard/google/brya/variants/pujjoga/gpio.c +++ b/src/mainboard/google/brya/variants/pujjoga/gpio.c @@ -44,8 +44,8 @@ static const struct pad_config override_gpio_table[] = { PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H17 : DDPB_CTRLDATA */ PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), - /* H19 : SOC_I2C_SUB_INT_ODL */ - PAD_CFG_GPI_LOCK(GPP_H19, NONE, LOCK_CONFIG), + /* H19 : SOC_I2C_SUB_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_H19, NONE, PLTRST, LEVEL, NONE), /* H21 : WWAN_PERST_L */ PAD_NC_LOCK(GPP_H21, NONE, LOCK_CONFIG), /* H22 : WCAM_MCLK_R ==> NC */ diff --git a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb index 789e578081..8877c41da9 100644 --- a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb @@ -303,7 +303,9 @@ chip soc/intel/alderlake register "int_comp_resistor" = ""lowest"" register "input_precharge_resistor_ohms" = "4000" register "input_analog_gain" = "1" - device i2c 28 on end + device i2c 28 on + probe WWAN LTE_PRESENT + end end end device ref i2c3 on