sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

die() does never return. Annotate it as such.

Browse Source 
Any endless loop after die() can be eliminated.
Dereferencing a NULL pointer is bad. die() instead.
Replace endless loops with die().

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Peter Stuge <peter@stuge.se>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4340 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Carl-Daniel Hailfinger
2009-06-05 11:41:51 +00:00
parent 28d71b9445
commit 87e7050bff
4 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/devices/pci_ops.c
View File

@@ -30,7 +30,7 @@ static struct bus *get_pbus(device_t dev)
struct bus *pbus;
if (!dev)
printk_alert("get_pbus: dev is NULL!\n");
die("get_pbus: dev is NULL!\n");
pbus = dev->bus;
@@ -44,9 +44,8 @@ static struct bus *get_pbus(device_t dev)
pbus = pbus->dev->bus;
}
if (!pbus || !pbus->dev || !pbus->dev->ops || !pbus->dev->ops->ops_pci_bus) {
printk_alert("%s Cannot find pci bus operations", dev_path(dev));
printk_emerg("%s Cannot find pci bus operations\n", dev_path(dev));
die("");
for(;;);
}
return pbus;
}

1
src/devices/smbus_ops.c
View File

@@ -34,7 +34,6 @@ struct bus *get_pbus_smbus(device_t dev)
if (!pbus || !pbus->dev || !pbus->dev->ops || !pbus->dev->ops->ops_smbus_bus) {
printk_alert("%s Cannot find smbus bus operations", dev_path(dev));
die("");
for(;;);
}
return pbus;
}